Closed Bug 1486787 Opened 6 years ago Closed 6 years ago

[remote-dbg-next] Use links for sidebar items

Categories

(DevTools :: about:debugging, enhancement, P1)

Product:
DevTools
Component:
about:debugging
Type:
enhancement

Tracking

(firefox65 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 65
Tracking Flags:
Tracking Status
firefox65 --- fixed

People

(Reporter: jdescottes, Assigned: ladybenko)

References

Details

Attachments

(1 file)

Bug 1486787 - Use links in sidebar items. r=jdescottes,daisuke
46 bytes, text/x-phabricator-request
Details | Review 
From review of Bug 1482868. Ideally, our selectable sidebar items should be links (<a>) that, when clicked, trigger a navigation which is intercepted by a router. 


The router should be implemented in Bug 1479746
Severity: normal → enhancement
Priority: -- → P3
Priority: P3 → P2
Assignee: nobody → balbeza
Status: NEW → ASSIGNED
Priority: P2 → P1
Selectable items now are wrapped into a `<a>` tag. Also made `SidebarItem`'s `onSelect` prop non mandatory if `selectable` is `false`.
Pushed by balbeza@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/31110d0d110a
Use links in sidebar items. r=jdescottes,daisuke
https://hg.mozilla.org/mozilla-central/rev/31110d0d110a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox65: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 65
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: