Closed
Bug 1486798
Opened 6 years ago
Closed 6 years ago
[remote-dbg-next] Clicking on "Connect" twice leads to JS error
Categories
(DevTools :: about:debugging, defect, P1)
DevTools
about:debugging
Tracking
(firefox63 fixed)
RESOLVED
FIXED
Firefox 63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: jdescottes, Assigned: jdescottes)
References
Details
Attachments
(1 file)
Clicking on "Connect" twice leads to the following JS error resource://devtools/shared/base-loader.js -> resource://devtools/client/aboutdebugging-new/src/middleware/debug-target-listener.js, line 69: TypeError: client is null, can't access property "removeListener" of it
Assignee | ||
Updated•6 years ago
|
Blocks: remote-debugging-ng-m1
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → jdescottes
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
This patch just checks if the selected page actually changes before dispatching any action in actions/ui.js::selectPage(). Interestingly this highlighted an inconsistency with our default state. The default page in ui-state is THIS_FIREFOX, however, unless we call selectPage(THIS_FIREFOX), we will not connect to the runtime and will not display any target. Here I updated the default value of the selectedPage to null.
Comment 3•6 years ago
|
||
Comment on attachment 9004579 [details] Bug 1486798 - Do not connect/disconnect when selecting the same page again;r=daisuke Daisuke Akatsuka (:daisuke) has approved the revision.
Attachment #9004579 -
Flags: review+
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2f46b98d41d9 Do not connect/disconnect when selecting the same page again;r=daisuke
Comment 5•6 years ago
|
||
Backed out for eslint failure at builds/worker/checkouts/gecko/devtools/client/aboutdebugging-new/src/reducers/ui-state.js Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=2f46b98d41d972528a464e182fee8fa4fd66c167 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=196416057&repo=autoland&lineNumber=269 Backout: https://hg.mozilla.org/integration/autoland/rev/04496c317e45820ca51b8ec45a2ecf85eccfb7fd
Flags: needinfo?(jdescottes)
Assignee | ||
Updated•6 years ago
|
Flags: needinfo?(jdescottes)
Pushed by jdescottes@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c9f1368e291f Do not connect/disconnect when selecting the same page again;r=daisuke
Comment 7•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c9f1368e291f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Updated•6 years ago
|
Priority: P3 → P1
You need to log in
before you can comment on or make changes to this bug.
Description
•