Closed
Bug 1486892
Opened 6 years ago
Closed 6 years ago
./mach raptor-test fails when checking for binary path
Categories
(Testing :: Raptor, defect)
Testing
Raptor
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: bc, Assigned: bc)
References
Details
Attachments
(1 file)
|
2.69 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
$ ./mach raptor-test --test raptor-speedometer --app geckoview --binary org.mozilla.geckoview_example Binary expected at /home/bclary/mozilla/builds/inbound-taskcluster/mozilla/fennec-opt-arm/dist/bin/fennec does not exist. testing/raptor/mach_commands.py calls MozbuldObject's get_binary_path() which fails since it is checking for the fennec file in dist/bin. We can work around this by not checking for the binary if the app is geckoview.
|
Assignee | |
Comment 1•6 years ago
|
||
Attachment #9004643 -
Flags: review?(jmaher)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9004643 [details] [diff] [review] do-not-check-binary-for-geckoview.patch Review of attachment 9004643 [details] [diff] [review]: ----------------------------------------------------------------- this is nice and simple, thanks
Attachment #9004643 -
Flags: review?(jmaher) → review+
Pushed by bclary@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/22ea38eafe06 Do not check for binary path when calling raptor via mach, r=jmaher.
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/22ea38eafe06
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•