Browser restarts should use launcher process when --enable-launcher-process is set

RESOLVED FIXED in Firefox 63

Status

()

enhancement
P1
normal
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: aklotz, Assigned: aklotz)

Tracking

(Blocks 1 bug)

Trunk
Firefox 63
Unspecified
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox63 fixed)

Details

(Whiteboard: inj+)

Attachments

(3 attachments)

Things like safe mode restarts, restarting from the profile manager, etc.
This patch causes Firefox processes created via LaunchChild to start via the
launcher process.

While this extra hop through the launcher process takes longer than if we were
to simply make LaunchChild use the same code as the launcher process itself,
I do not want to simply export LauncherProcessMain from firefox.exe, as that
would be too easy to hook into and mess with.

Another option would be to host a second copy of the launcher code inside
xul.dll, but that's less than ideal.

Anyway, until we get that figured out, I don't think it's too big a deal to
have this extra hop in place. I don't think anybody has been clamoring for
faster restarts from the updater or the profile manager.

Depends on D4496
Comment on attachment 9004711 [details]
Bug 1486901: Part 1 - Allow RunAsLauncherProcess to fall back to environment and command line if the parent process check does not return true; r=mhowell!

Matt Howell [:mhowell] has approved the revision.
Attachment #9004711 - Flags: review+
Comment on attachment 9004712 [details]
Bug 1486901: Part 2 - Set MOZ_LAUNCHER_PROCESS when the launcher process is enabled by default and restarting via LaunchChild; r=mhowell!

Matt Howell [:mhowell] has approved the revision.
Attachment #9004712 - Flags: review+
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6f6c28eb6041
Part 1 - Allow RunAsLauncherProcess to fall back to environment and command line if the parent process check does not return true; r=mhowell!
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/511ad3e51be3
Part 2 - Set MOZ_LAUNCHER_PROCESS when the launcher process is enabled by default and restarting via LaunchChild; r=mhowell!
https://hg.mozilla.org/mozilla-central/rev/6f6c28eb6041
https://hg.mozilla.org/mozilla-central/rev/511ad3e51be3
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
In the wee hours of last night, I realized that there is a bug in this code. I need to land a follow-up patch.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 9004978 [details]
Bug 1486901: Part 3 - Ensure that all RunAsLauncherProcess tests run to ensure side effects; r=mhowell!

Matt Howell [:mhowell] has approved the revision.
Attachment #9004978 - Flags: review+
Pushed by aklotz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cf15e6faf983
Part 3 - Ensure that all RunAsLauncherProcess tests run to ensure side effects; r=mhowell!
https://hg.mozilla.org/mozilla-central/rev/cf15e6faf983
Status: REOPENED → RESOLVED
Closed: 11 months ago11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.