Closed Bug 1486909 Opened 6 years ago Closed 6 years ago

JavaScript error TopSitesFeed setting getter-only property "_currentSearchHostname"

Categories

(Firefox :: New Tab Page, defect, P1)

Product:
Firefox
Component:
New Tab Page
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 64
Iteration:
64.1 - Sep 14
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox62 --- wontfix
firefox63 --- wontfix
firefox64 --- fixed

People

(Reporter: Mardak, Assigned: andreio)

References

Details

JavaScript error: resource://activity-stream/lib/TopSitesFeed.jsm, line 86: TypeError: setting getter-only property "_currentSearchHostname"

This line is from uninit, but looks like there's some other (unnecessary?) assignment to _currentSearchHostname in the code.

https://searchfox.org/mozilla-central/search?q=_currentSearchHostname
Assignee: nobody → andrei.br92
Iteration: --- → 64.1 (Sep 14)
Priority: -- → P1
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/3dbea5ef64b3710e5bbaf3e0c1ea2244e4a5f287
Fix Bug 1486909 - Fix JavaScript error in TopSitesFeed for _currentSearchHostname
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
What's the impact of this issue? Do we need to consider backporting this fix?
Blocks: 1482579
status-firefox62: --- → affected
status-firefox-esr60: --- → unaffected
No longer depends on: 1482579
Flags: needinfo?(andrei.br92)
This was just a warning meant to prevent improper use. We only noticed it during mochitest runs. I think getting flaged by Intermittent Robot was just a concidence because the word "Error" shows up in the log.
Flags: needinfo?(andrei.br92)
Sounds like the fix can just ride the trains then, thanks.
status-firefox62: affected → wontfix
status-firefox63: affected → wontfix
Blocks: 1489962
Backout by btara@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/d2e41f2f964d
Backed out changeset 8dde92f89a24 for browser_asrouter_cfr.js failures. a=backout

Relanded:
https://hg.mozilla.org/mozilla-central/rev/581019e9ea70
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.