Closed Bug 1486926 Opened Last year Closed Last year

Make the Disable Protection button in the control centre UI work for the reject foreign cookie behavior

Categories

(Core :: DOM: Security, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: ehsan, Assigned: ehsan)

References

Details

Attachments

(5 files)

Similar to bug 1486185 but for the reject foreign cookie behavior this time.
Attachment #9004692 - Flags: review?(amarchesini) → review+
Comment on attachment 9004693 [details] [diff] [review]
Part 2: Refactor the antitracking mini-testsuite to make it pass the full cookieBehavior everywhere instead of a boolean

Review of attachment 9004693 [details] [diff] [review]:
-----------------------------------------------------------------

nice.
Attachment #9004693 - Flags: review?(amarchesini) → review+
Attachment #9004694 - Flags: review?(amarchesini) → review+
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20f625526901
Part 1: Make the Disable Protection button in the control centre UI work for the reject foreign cookie behavior; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6533c40954f
Part 2: Refactor the antitracking mini-testsuite to make it pass the full cookieBehavior everywhere instead of a boolean; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/fef913dda33d
Part 3: Add tests to ensure that the reject foreign cookie behavior honours the Content Blocking allow list; r=baku
Otherwise, this function will fail when the THIRD_PARTY_FORCE_ALLOW flag has
been set on the channel.
Attachment #9004865 - Flags: review?(amarchesini)
Comment on attachment 9004861 [details] [diff] [review]
Part 4: Check the return value of IsThirdPartyChannel() in IsFirstPartyStorageAccessGrantedFor()

Review of attachment 9004861 [details] [diff] [review]:
-----------------------------------------------------------------

have you checked other uses in AntiTrackingCommon code?
Attachment #9004861 - Flags: review?(amarchesini) → review+
Attachment #9004865 - Flags: review?(amarchesini) → review+
(In reply to Andrea Marchesini [:baku] from comment #9)
> Comment on attachment 9004861 [details] [diff] [review]
> Part 4: Check the return value of IsThirdPartyChannel() in
> IsFirstPartyStorageAccessGrantedFor()
> 
> Review of attachment 9004861 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> have you checked other uses in AntiTrackingCommon code?

There aren't any others!
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5093d71e4d21
Part 1: Make the Disable Protection button in the control centre UI work for the reject foreign cookie behavior; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f02c577646a
Part 2: Refactor the antitracking mini-testsuite to make it pass the full cookieBehavior everywhere instead of a boolean; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a7a27ada2fc
Part 3: Add tests to ensure that the reject foreign cookie behavior honours the Content Blocking allow list; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/4074f7b21fa4
Part 4: Check the return value of IsThirdPartyChannel() in IsFirstPartyStorageAccessGrantedFor(); r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e7fc27e6660
Part 5: Pass the URI being checked to IsThirdPartyChannel() in IsFirstPartyStorageAccessGrantedFor(); r=baku
You need to log in before you can comment on or make changes to this bug.