1486926 - Make the Disable Protection button in the control centre UI work for the reject foreign cookie behavior

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement)

Description

[(no longer active)]

Similar to bug 1486185 but for the reject foreign cookie behavior this time.

Comment 1

[(no longer active)]

Attachment: Part 1: Make the Disable Protection button in the control centre UI work for the reject foreign cookie behavior

Comment 2

[(no longer active)]

Attachment: Part 2: Refactor the antitracking mini-testsuite to make it pass the full cookieBehavior everywhere instead of a boolean

Comment 3

[(no longer active)]

Attachment: Part 3: Add tests to ensure that the reject foreign cookie behavior honours the Content Blocking allow list

Comment 4

[Andrea Marchesini [:baku]]

Comment on attachment 9004693 [details] [diff] [review]
Part 2: Refactor the antitracking mini-testsuite to make it pass the full cookieBehavior everywhere instead of a boolean

Review of attachment 9004693 [details] [diff] [review]:
-----------------------------------------------------------------

nice.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/20f625526901
Part 1: Make the Disable Protection button in the control centre UI work for the reject foreign cookie behavior; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/f6533c40954f
Part 2: Refactor the antitracking mini-testsuite to make it pass the full cookieBehavior everywhere instead of a boolean; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/fef913dda33d
Part 3: Add tests to ensure that the reject foreign cookie behavior honours the Content Blocking allow list; r=baku

Comment 6

[(no longer active)]

Attachment: Part 4: Check the return value of IsThirdPartyChannel() in IsFirstPartyStorageAccessGrantedFor()

Comment 7

[(no longer active)]

Attachment: Part 5: Pass the URI being checked to IsThirdPartyChannel() in IsFirstPartyStorageAccessGrantedFor()

Otherwise, this function will fail when the THIRD_PARTY_FORCE_ALLOW flag has
been set on the channel.

Comment 8

[Tiberius Oros[:tiberius_oros]]

Backed out 5 changesets (bug 1486926)for multiple failures

Backout push: https://hg.mozilla.org/integration/mozilla-inbound/rev/b6be51ee00aa8a2a18962d8074e804d5c75186e0

Pushes with the failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=fef913dda33d078a92d24b526d6e047ca157634b
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=b536e2deff083321e88293769360f3be8042baba

Failures and log files:
- browser chrome failures at browser/components/enterprisepolicies/tests/browser/browser_policy_cookie_settings.js
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=fef913dda33d078a92d24b526d6e047ca157634b&selectedJob=196439983

- xpcshell failures at extensions/cookie/test/unit/test_cookies_thirdparty.js
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=fef913dda33d078a92d24b526d6e047ca157634b&selectedJob=196439061

Comment 9

[Andrea Marchesini [:baku]]

Comment on attachment 9004861 [details] [diff] [review]
Part 4: Check the return value of IsThirdPartyChannel() in IsFirstPartyStorageAccessGrantedFor()

Review of attachment 9004861 [details] [diff] [review]:
-----------------------------------------------------------------

have you checked other uses in AntiTrackingCommon code?

Comment 10

[(no longer active)]

(In reply to Andrea Marchesini [:baku] from comment #9)
> Comment on attachment 9004861 [details] [diff] [review]
> Part 4: Check the return value of IsThirdPartyChannel() in
> IsFirstPartyStorageAccessGrantedFor()
> 
> Review of attachment 9004861 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> have you checked other uses in AntiTrackingCommon code?

There aren't any others!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5093d71e4d21
Part 1: Make the Disable Protection button in the control centre UI work for the reject foreign cookie behavior; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f02c577646a
Part 2: Refactor the antitracking mini-testsuite to make it pass the full cookieBehavior everywhere instead of a boolean; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/3a7a27ada2fc
Part 3: Add tests to ensure that the reject foreign cookie behavior honours the Content Blocking allow list; r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/4074f7b21fa4
Part 4: Check the return value of IsThirdPartyChannel() in IsFirstPartyStorageAccessGrantedFor(); r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e7fc27e6660
Part 5: Pass the URI being checked to IsThirdPartyChannel() in IsFirstPartyStorageAccessGrantedFor(); r=baku

Comment 12

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/5093d71e4d21
https://hg.mozilla.org/mozilla-central/rev/3f02c577646a
https://hg.mozilla.org/mozilla-central/rev/3a7a27ada2fc
https://hg.mozilla.org/mozilla-central/rev/4074f7b21fa4
https://hg.mozilla.org/mozilla-central/rev/7e7fc27e6660