Closed Bug 1486938 Opened 2 years ago Closed 2 years ago

Get rid of "login-manager-storage" category entry

Categories

(Toolkit :: Password Manager, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: kmag, Assigned: kmag)

Details

Attachments

(1 file)

This is a pretty weird use of the category manager, which seems to be completely unused. We generally handle these sorts of things (if we handle them in an XPCOM-ish way at all) by allowing implementors to override a contract ID. If we need such an override again, it can be handled in that way without any extra code.
This is an unused feature, with a strange implementation. If we need such an
override in the future, it can be accomplished by just overriding a contract
ID.

This patch also changes the implementation to simply define a contract ID for
the appropriate default implementation at registration time rather than adding
a duplicate platform check at runtime.
Comment on attachment 9004709 [details]
Bug 1486938: Remove login-manager-storage category entry. r=MattN

Matthew N. [:MattN] (PM if requests are blocking you) has approved the revision.
Attachment #9004709 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/f52b086cbd9d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.