1486939 - GeckoSession shouldn't allow multiple consumers to hold the GeckoDisplay

Status: RESOLVED WORKSFORME

(GeckoView :: General, enhancement, P3)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Right now GeckoSession.acquireDisplay() is essentially a getter. This isn't very safe, since we could have many callers trying to set surfaces, etc. It also betrays the "acquire" naming, which normally means the caller will get exclusive rights.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1486939 - Enforce exclusive ownership of GeckoDisplay r=jchen,droeh

This also ensures GeckoSession only listens to the
currently acquired GeckoDisplay.

I'd like to put a bunch more tests in DisplayTests
to ensure the right stuff goes into the provided
Surface, etc.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 9004708 [details]
Bug 1486939 - Enforce exclusive ownership of GeckoDisplay r=jchen,droeh

Jim Chen [:jchen] [:darchons] has approved the revision.