Closed Bug 1486951 Opened 2 years ago Closed 2 years ago

Change accesskey for DNS over HTTPS label

Categories

(Firefox :: Preferences, defect, P1)

Product:
Firefox
Component:
Preferences
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 + fixed

People

(Reporter: sfoster, Assigned: sfoster)

References

Details

Attachments

(1 file)

Bug 1486951 - Change accesskey for Enable DNS over HTTPS label. r=flod
46 bytes, text/x-phabricator-request
flod
: review+
Details | Review 
From comment 18 on Bug 1482271

> Fwiw: for "Enable DNS over HTTPS", the b is available, and when ignoring the
> XUL Accesskey Policy for strings with descenders (which is already done for
> the one pixel wide i character), g could be used in "Use system proxy
> settings" to free the U for URL. I would recommend to avoid the H because of
> Help buttons already present or possibly getting introduced in all cases,
> and the above appears to work.

Adding "Enable" to this string was a late change and I didn't re-evaluate the available accesskeys. Using 'b' looks like a good suggestion.
Note that you shouldn't change the string ID to update accesskeys in English.
Is this something we needed to address in 63 before the merge?
Flags: needinfo?(sfoster)
(In reply to Mike Conley (:mconley) (:⚙️) from comment #2)
> Is this something we needed to address in 63 before the merge?

I'd say it's something to address before the final merge of 63 to beta, to avoid either having inconsistent values in 63 or 64, or having to request uplift.
[Tracking Requested - why for this release]:
See comment #3
Blocks: 1482271
status-firefox61: --- → unaffected
status-firefox62: --- → unaffected
status-firefox63: --- → affected
tracking-firefox63: --- → ?
Priority: -- → P1
Here's a patch that just does the accesskey switch on the new 'Enable DNS over HTTPS" label. I could also follow the rest of :Tonnes' suggestion, but that involves changing accesskeys for existing content and from Comment #3 I'm thinking we should be more cautious about that?
Flags: needinfo?(sfoster)
Comment on attachment 9005455 [details]
Bug 1486951 - Change accesskey for Enable DNS over HTTPS label. r=flod

Francesco Lodolo [:flod] has approved the revision.
Attachment #9005455 - Flags: review+
Assignee: nobody → sfoster
Status: NEW → ASSIGNED
Pushed by sfoster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ee4ea4aee38
Change accesskey for Enable DNS over HTTPS label. r=flod
https://hg.mozilla.org/mozilla-central/rev/5ee4ea4aee38
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.