1487013 - The new folder created doesn't have any title

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect, P3)

Description

[Stefan Deiac]

Environment: 
Device: OnePlus 5T (Android 8.1.0);

Steps to reproduce:
1. Open Bookmarks; 
2. Long tap on a link;
3. Choose edit;
4. Tap on Parent folder;
5. Tap on "folder+" sign from Toolbar - right);
6. Save the new folder without any name.


Expected result:
The new folder created has a predefined "(no title)" name.

Actual result:
The new folder created doesn't have any title.

Notes:
Desktop version of Firefox displays the folder with the predefined "(no title)" name. The mobile version of FF should follow the same implementation as Desktop.

Comment 1

[Stefan Deiac]

Update: After creating the folder, if you long tap on it, space where should be the name it's empty.

Comment 2

[Marcia Knous [:marcia]]

During triage, we discussed this being a P3 issue. Having parity with desktop would be nice, but at this time this doesn't sound like a high priority item.

Comment 3

[Diana Iacos]

Attachment: Bug 1487013 - The new folder created doesn't have any title; r?petru

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/913933ff0e8e
The new folder created doesn't have any title; r=petru

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/913933ff0e8e

Comment 6

[Chris Peterson [:cpeterson]]

Diana, please request uplift to Fennec 68 Beta so we can ship your fix in Fennec 68 ESR.

Comment 7

[Diana Iacos]

Comment on attachment 9069952 [details]
Bug 1487013 - The new folder created doesn't have any title; r?petru

Beta/Release Uplift Approval Request

• User impact if declined: The new folder will be without any title.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: 1. Open Bookmarks;

2. Long tap on a link;
3. Choose edit;
4. Tap on Parent folder;
5. Tap on "folder+" sign from Toolbar - right);
6. Save the new folder without any name.

Expected result:
The new folder created has a predefined "(no title)" name.

Actual result:
The new folder created doesn't have any title.

• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes are not risky because we added only a condition to check if the folder’s title added by the user it’s empty.
• String changes made/needed: The string that was added : bookmark_default_folder_title

Comment 8

[Julien Cristau [:jcristau] (back April 22)]

Comment on attachment 9069952 [details]
Bug 1487013 - The new folder created doesn't have any title; r?petru

fennec bookmark fix, approved for 68.0b9

Comment 9

[Julien Cristau [:jcristau] (back April 22)]

https://hg.mozilla.org/releases/mozilla-beta/rev/78928eb0791e

Comment 10

[Eliza Balazs]

Verified as fixed on Nightly 69.0a1 (2019-06-10), Beta 68.0b9 with Samsung Galaxy S8 (Android 9).
Due to my findings, I'll mark this issue as verified. Thanks.