Closed Bug 1487027 Opened 4 years ago Closed 4 years ago

urlbar bindings get confused when the overflow event for the input placeholder fires

Categories

(Firefox :: Address Bar, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 63
Tracking Status
firefox63 --- verified
firefox64 --- verified

People

(Reporter: emilio, Assigned: emilio)

References

(Depends on 1 open bug)

Details

Attachments

(1 file)

This is the root cause for bug 1486957.

If you resize the urlbar around you can see the overflow events make the shadow disappear when enlargening over the placeholder.
Priority: -- → P1
Actually the "don't dispatch it for NAC" doesn't quite work and suppresses too many events. So I guess the urlbar bindings would need to get smarter to handle this somehow. But it's hard because the event target can't be differentiated...

I'll poke a bit more at it but I may not be able to work on it if it gets very complex.
I can special-case placeholders here, but that's not great. Ideally what should happen is that placeholders aren't actually laid out when not showing.

That's hard for other reasons, but that should fire overflow events for the placeholder nicely, and same for the input box, only when they're showing.

I'll file a bug to track that, but it's unlikely that I get to fix this. The urlbar can check whether the target is the placeholder via originalTarget (though that's actually a bit unexpected).
Depends on: 1487036
Filed bug 1487036 for a fix that would avoid triggering events for the
placeholder when it's not showing, though realistically I'm not going to have
cycles to fix it.

Probably moving the <input> to Shadow DOM would allow such a solution, but it's
not clear we want to do that just yet at least.
Comment on attachment 9004816 [details]
Don't care about the placeholder overflow events.

Dão Gottwald [::dao] has approved the revision.
Attachment #9004816 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/380cf66149e2
Don't care about the placeholder overflow events. r=dao
https://hg.mozilla.org/mozilla-central/rev/380cf66149e2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Is there anything else we should cover in addition to what was mentioned in 1486957?
Flags: qe-verify+
Flags: needinfo?(emilio)
I don't think so, thanks for checking!
Flags: needinfo?(emilio)
I managed to reproduce the issue using an older version of Nightly (2018-08-29) on Windows 10 x64.
I retested everything using latest Nightly 64.0a1 and beta 63.0b11 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13. The bug is not reproducing anymore.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.