1487027 - urlbar bindings get confused when the overflow event for the input placeholder fires

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Emilio Cobos Álvarez [:emilio]]

This is the root cause for bug 1486957.

If you resize the urlbar around you can see the overflow events make the shadow disappear when enlargening over the placeholder.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Actually the "don't dispatch it for NAC" doesn't quite work and suppresses too many events. So I guess the urlbar bindings would need to get smarter to handle this somehow. But it's hard because the event target can't be differentiated...

I'll poke a bit more at it but I may not be able to work on it if it gets very complex.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

I can special-case placeholders here, but that's not great. Ideally what should happen is that placeholders aren't actually laid out when not showing.

That's hard for other reasons, but that should fire overflow events for the placeholder nicely, and same for the input box, only when they're showing.

I'll file a bug to track that, but it's unlikely that I get to fix this. The urlbar can check whether the target is the placeholder via originalTarget (though that's actually a bit unexpected).

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Attachment: Don't care about the placeholder overflow events.

Filed bug 1487036 for a fix that would avoid triggering events for the
placeholder when it's not showing, though realistically I'm not going to have
cycles to fix it.

Probably moving the <input> to Shadow DOM would allow such a solution, but it's
not clear we want to do that just yet at least.

Comment 4

[Dão Gottwald [:dao]]

Comment on attachment 9004816 [details]
Don't care about the placeholder overflow events.

Dão Gottwald [::dao] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/380cf66149e2
Don't care about the placeholder overflow events. r=dao

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/380cf66149e2

Comment 7

[Camelia Badau [:cbadau], Desktop Test Engineering]

Is there anything else we should cover in addition to what was mentioned in 1486957?

Comment 8

[Emilio Cobos Álvarez [:emilio]]

I don't think so, thanks for checking!

Comment 9

[Oana Botisan, Desktop QA]

I managed to reproduce the issue using an older version of Nightly (2018-08-29) on Windows 10 x64.
I retested everything using latest Nightly 64.0a1 and beta 63.0b11 on Windows 10 x64, Ubuntu 16.04 x64 and macOS 10.13. The bug is not reproducing anymore.