1487049 - Update opus to revision v1.3-rc-15-g38fca4a2

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Dan Minor [:dminor]]

The latest tag is v1.3-rc.

Jean-Marc, do you recommend using the release candidate, current master, or waiting for the v1.3 release? If the latter, do you have a timeline for that release? Thanks!

Comment 1

[Jean-Marc Valin]

I think the latest master (38fca4a203a6759f2c90b86c84c4db087982ca81) is probably best here. I'm about to release it as 1.3-rc2, and hopefully 1.3-final soon after.

Comment 2

[Dan Minor [:dminor]]

Thanks! I'll plan on updating to 1.3-rc2.

Comment 3

[Dan Minor [:dminor]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=602c084c953962bf0d830c4dffe808c021ccc3b5

Comment 4

[Dan Minor [:dminor]]

Attachment: Bug 1487049 - Add opus_projection.h to HDR_FILES in libopus/update.sh; r=jmspeex

Comment 5

[Dan Minor [:dminor]]

Attachment: Bug 1487049 - Update libopus to 1.3-rc2; r=jmspeex

Comment 6

[Dan Minor [:dminor]]

Attachment: Bug 1487049 - Update libopus non-unified build files; r=jmspeex

Comment 7

[Dan Minor [:dminor]]

Hi Jean-Marc, I was planning to ask you for review on this but you don't have a Phabricator account. I was wondering if you could create an account or let me know if there is someone else who would be a suitable reviewer? Thank you!

Comment 8

[Jean-Marc Valin]

See comment in Phabricator.

Comment 9

[Dan Minor [:dminor]]

Attachment: Bug 1487049 - Set ENABLE_HARDENING for libopus; r=jmvalin

Comment 10

[Jean-Marc Valin]

Comment on attachment 9006233 [details]
Bug 1487049 - Set ENABLE_HARDENING for libopus; r=jmvalin

Jean-Marc Valin (:jmspeex) has approved the revision.

Comment 11

[Dan Minor [:dminor]]

I discussed this with drno and we're going to take v1.3-rc-15-g38fca4a2 rather than wait for a 1.3 release or the next release candidate.

Comment 12

[Jean-Marc Valin]

OK, sounds reasonable and I'm fairly confident of that commit.

Comment 13

[Jean-Marc Valin]

Comment on attachment 9005490 [details]
Bug 1487049 - Update libopus non-unified build files; r=jmspeex

Jean-Marc Valin (:jmspeex) has approved the revision.

Comment 14

[Jean-Marc Valin]

Comment on attachment 9005489 [details]
Bug 1487049 - Update libopus to 1.3-rc2; r=jmspeex

Jean-Marc Valin (:jmspeex) has approved the revision.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f2915028e3f
Update libopus to v1.3-rc-19-g5cbd7d5f; r=jmspeex
https://hg.mozilla.org/integration/mozilla-inbound/rev/87c44124c772
Update libopus non-unified build files; r=jmspeex
https://hg.mozilla.org/integration/mozilla-inbound/rev/309d6b502c71
Set ENABLE_HARDENING for libopus; r=jmspeex

Comment 16

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/5f2915028e3f
https://hg.mozilla.org/mozilla-central/rev/87c44124c772
https://hg.mozilla.org/mozilla-central/rev/309d6b502c71