1487103 - AddonManager.removeUpgradeListener(...) is undefined, can't access property "catch" of it (via runtime.onUpdateAvailable)

Status: RESOLVED FIXED

(WebExtensions :: General, defect)

Description

[Rob Wu [:robwu]]

I just saw the following error in the console on Nightly:

AddonManager.removeUpgradeListener(...) is undefined, can't access property "catch" of it ext-runtime.js:92
getAPI/register/<.runtime.onUpdateAvailable
chrome://extensions/content/parent/ext-runtime.js:92:15
removeListener
resource://gre/modules/ExtensionCommon.jsm:2241:7
revoke
resource://gre/modules/ExtensionCommon.jsm:2263:7
close
resource://gre/modules/ExtensionCommon.jsm:2268:5
unload
resource://gre/modules/ExtensionCommon.jsm:733:7
unload
resource://gre/modules/ExtensionParent.jsm:614:5
unload
resource://gre/modules/ExtensionParent.jsm:696:5
closeProxyContext
resource://gre/modules/ExtensionParent.jsm:878:7
observe
resource://gre/modules/ExtensionParent.jsm:777:11

Triggered at: https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/toolkit/components/extensions/parent/ext-runtime.js#92

The .catch was introduced in bug 1356826,
but removeUpgradeListener does not return a promise any more as of bug 1454202:
https://searchfox.org/mozilla-central/diff/2b0ca40c39ced98694a88df2f7a718e7f4cd7abe/toolkit/mozapps/extensions/AddonManager.jsm#2056

I didn't load any external extension that used runtime.onUpdateAvailable.
The internal formautofill component uses it though, as of bug 1449055 :
https://searchfox.org/mozilla-central/rev/55da592d85c2baf8d8818010c41d9738c97013d2/browser/extensions/formautofill/background.js#5

Comment 1

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/af99701b058f487afa740d47431ceb290b3cf3eb
Bug 1487103: Remove useless .catch(). r=trivial

Comment 2

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/af99701b058f

Comment 3

[Vlad Jiman]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!