Closed Bug 1487118 Opened 6 years ago Closed 6 years ago

Cleanup CFR recommendations when the experiment/ASRouter gets disabled

Categories

(Firefox :: Messaging System, defect, P1)

Product:
Firefox
Component:
Messaging System
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 63
Iteration:
63.5 - Sep 3
Tracking Flags:
Tracking Status
firefox63 --- verified
firefox64 --- verified

People

(Reporter: ahillier, Assigned: ahillier)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Link to GitHub pull-request: https://github.com/mozilla/activity-stream/pull/4390
52 bytes, text/x-github-pull-request
Details | Review 
      No description provided.
Assignee: nobody → ahillier
Commit pushed to master at https://github.com/mozilla/activity-stream

https://github.com/mozilla/activity-stream/commit/f0daf8921ff56b9eaa0c13b0712c43f8094b6ce2
Fix Bug 1487118: hide all recommendations when the ASRouter gets disabled (#4390)
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Blocks: 1487538
https://hg.mozilla.org/mozilla-central/rev/8937a84b0811
Iteration: --- → 63.5 - Sep 3
status-firefox63: --- → fixed
Priority: -- → P1
Target Milestone: --- → Firefox 63
I have verified that setting the "browser.newtabpage.activity-stream.asrouterExperimentEnabled" pref to "false" will hide/dismiss any active recommendations on Nightly 63.0a1 (20180902220539) on Windows 10 x64, Mac 10.13.3, and Arch Linux x64 and setting the "browser.newtabpage.activity-stream.feeds.asrouterfeed" pref to "false" on both Nightly 63.0a1 and Nightly 64.0a1 (20180923220427) will hide/dismiss any active recommandations on the same platforms.
Status: RESOLVED → VERIFIED
status-firefox63: fixed → verified
status-firefox64: --- → verified
Component: Activity Streams: Newtab → Messaging System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: