Closed Bug 1487190 Opened Last year Closed Last year

Update bugzilla metadata in moz.build to reflect Layout components reorganization in bug 1484408

Categories

(Core :: Layout, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: aryx, Assigned: aryx)

References

Details

Attachments

(1 file)

Still necessary to know what changed for

Layout: Images

The added components are not enabled yet
Component: Administration → Layout
Product: bugzilla.mozilla.org → Core
Version: Production → unspecified
Thank you for doing this Sebastian!  There are some further refinements that can be done to map files to the newly created components, e.g. mapping nsFlexContainerFrame.{h,cpp} to "Layout: Flexbox".
My expectation is that someone from the Layout team does this so not so obvious files don't get missed. The patch currently attached is just for fixing treeherder's bug filer which suggests the old components but then rejects to create the bug because the component is missing.
I kinda recall that there was some plan to move this information out of tree?
Attachment #9005116 - Attachment description: Bug 1487190 - Update bugzilla metadata in moz.build files to reflect Layout components reorganization in bug 1484408. r?mccr8 → Bug 1487190 - Update bugzilla metadata in moz.build files to reflect Layout components reorganization in bug 1484408. r?heycam
Comment on attachment 9005116 [details]
Bug 1487190 - Update bugzilla metadata in moz.build files to reflect Layout components reorganization in bug 1484408. r?heycam

Cameron McCormack (:heycam) has approved the revision.
Attachment #9005116 - Flags: review+
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/9e0481c2413d
Update bugzilla metadata in moz.build files to reflect Layout components reorganization in bug 1484408. r=heycam
Backed out changeset 9e0481c2413d (bug 1487190) for breaking Gecko Decision Task. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=197576693&repo=autoland&lineNumber=2514

Reading file: /builds/worker/checkouts/gecko/layout/painting/moz.build
[task 2018-09-05T10:38:13.111Z] Reading file: /builds/worker/checkouts/gecko/layout/reftests/moz.build
[task 2018-09-05T10:38:13.115Z] Traceback (most recent call last):
[task 2018-09-05T10:38:13.115Z]   File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 183, in taskgraph_decision
[task 2018-09-05T10:38:13.115Z]     return taskgraph.decision.taskgraph_decision(options)
[task 2018-09-05T10:38:13.115Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/decision.py", line 171, in taskgraph_decision
[task 2018-09-05T10:38:13.115Z]     write_artifact('task-graph.json', tgg.morphed_task_graph.to_json())
[task 2018-09-05T10:38:13.115Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 203, in morphed_task_graph
[task 2018-09-05T10:38:13.115Z]     return self._run_until('morphed_task_graph')
[task 2018-09-05T10:38:13.115Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 320, in _run_until
[task 2018-09-05T10:38:13.115Z]     k, v = self._run.next()
[task 2018-09-05T10:38:13.116Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/generator.py", line 307, in _run
[task 2018-09-05T10:38:13.116Z]     existing_tasks=existing_tasks)
[task 2018-09-05T10:38:13.116Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 56, in optimize_task_graph
[task 2018-09-05T10:38:13.116Z]     do_not_optimize=do_not_optimize)
[task 2018-09-05T10:38:13.116Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 127, in remove_tasks
[task 2018-09-05T10:38:13.116Z]     if opt.should_remove_task(task, params, arg):
[task 2018-09-05T10:38:13.117Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 376, in should_remove_task
[task 2018-09-05T10:38:13.117Z]     scheduled = self.scheduled_by_push(params['head_repository'], params['head_rev'])
[task 2018-09-05T10:38:13.117Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/util.py", line 944, in method_call
[task 2018-09-05T10:38:13.117Z]     cache[args] = self.func(instance, *args)
[task 2018-09-05T10:38:13.117Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/optimize.py", line 367, in scheduled_by_push
[task 2018-09-05T10:38:13.117Z]     for p, m in rdr.files_info(changed_files).items():
[task 2018-09-05T10:38:13.117Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1328, in files_info
[task 2018-09-05T10:38:13.117Z]     paths, _ = self.read_relevant_mozbuilds(paths)
[task 2018-09-05T10:38:13.118Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1292, in read_relevant_mozbuilds
[task 2018-09-05T10:38:13.118Z]     self.config, metadata=metadata):
[task 2018-09-05T10:38:13.118Z]   File "/builds/worker/checkouts/gecko/python/mozbuild/mozbuild/frontend/reader.py", line 1047, in read_mozbuild
[task 2018-09-05T10:38:13.118Z]     raise bre
[task 2018-09-05T10:38:13.118Z] BuildReaderError: 
[task 2018-09-05T10:38:13.118Z] ==============================
[task 2018-09-05T10:38:13.118Z] FATAL ERROR PROCESSING MOZBUILD FILE
[task 2018-09-05T10:38:13.118Z] ==============================
[task 2018-09-05T10:38:13.118Z] 
[task 2018-09-05T10:38:13.119Z] The error occurred while processing the following file:
[task 2018-09-05T10:38:13.119Z] 
[task 2018-09-05T10:38:13.119Z]     /builds/worker/checkouts/gecko/layout/reftests/moz.build
[task 2018-09-05T10:38:13.119Z] 
[task 2018-09-05T10:38:13.119Z] The underlying problem is a Python syntax error on line 65:
[task 2018-09-05T10:38:13.119Z] 
[task 2018-09-05T10:38:13.119Z]         BUG_COMPONENT = ('Core', 'Layout: Text and Fonts)
[task 2018-09-05T10:38:13.119Z] 
[task 2018-09-05T10:38:13.119Z]                                                          ^
[task 2018-09-05T10:38:13.119Z] 
[task 2018-09-05T10:38:13.119Z] Fix the syntax error and try again.
[task 2018-09-05T10:38:13.119Z] 
[taskcluster 2018-09-05 10:38:13.945Z] === Task Finished ===

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=9e0481c2413db80153a5f4e7684619cad85b19ce&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-classifiedState=unclassified

Backout:
https://hg.mozilla.org/integration/autoland/rev/9769691088efaf8aabac8cf3012f499a9fecced4
Flags: needinfo?(aryx.bugmail)
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/834a75789c0a
Update bugzilla metadata in moz.build files to reflect Layout components reorganization in bug 1484408. r=heycam
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/7da7a3b5269d
Update bugzilla metadata in moz.build files to reflect Layout components reorganization in bug 1484408. r=heycam
https://hg.mozilla.org/mozilla-central/rev/7da7a3b5269d
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.