Closed Bug 1487195 Opened Last year Closed Last year

Set up moz.build files to use bugzilla's "Core :: CSS Transitions and Animations" for new bugs

Categories

(Core :: CSS Transitions and Animations, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: aryx, Assigned: birtles)

References

Details

Attachments

(1 file)

Bug 1485301 renamed a new bugzilla component to  "Core :: CSS Transitions and Animations". That should be added as bugzilla metadata to moz.build files for files whose issues should be filed into that component.

Docs at https://firefox-source-docs.mozilla.org/build/buildsystem/files-metadata.html
Flags: needinfo?(continuation)
I don't know why you are needinfoing me on this. Brian Birtles is the module owner for Animation, so I think he might know what files are associated with that component.
Flags: needinfo?(continuation) → needinfo?(bbirtles)
I think this should be:

layout/style/StyleAnimationValue.{h,cpp}
layout/style/nsAnimationManager.{h,cpp}
layout/style/nsTransitionManager.{h,cpp}

(I assume we can't add servo files, e.g. servo/components/style/properties/helpers/animated_properties.mako.rs ?)

Leaving ni to remind me to actually write the patch
(In reply to Brian Birtles (:birtles) from comment #2)
> (I assume we can't add servo files, e.g.
> servo/components/style/properties/helpers/animated_properties.mako.rs ?)

It turns out we can (there is a moz.build file in /servo) but thinking about it a bit more, I think animated_properties.mako.rs really belongs in DOM::Animation if anything. And I wonder if it's really worth going to that level of granularity there.
Flags: needinfo?(bbirtles)
Priority: -- → P3
Comment on attachment 9005559 [details]
Bug 1487195 - Add BUG_COMPONENT metadata for new "Core :: CSS Transitions and Animations" component; r=hiro

Hiroyuki Ikezoe (:hiro) (PTO on Aug 31) has approved the revision.
Attachment #9005559 - Flags: review+
Pushed by bbirtles@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b5d256c99f9
Add BUG_COMPONENT metadata for new "Core :: CSS Transitions and Animations" component; r=hiro
https://hg.mozilla.org/mozilla-central/rev/5b5d256c99f9
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Assignee: nobody → bbirtles
You need to log in before you can comment on or make changes to this bug.