1487237 - Add memory reporting for some more DOM slots members

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P3)

Description

[Boris Zbarsky [:bzbarsky]]

From a DMD report:

Unreported {
  1,448 blocks in heap block record 60 of 6,988
  324,352 bytes (312,768 requested / 11,584 slop)
  Individual block sizes: 224 x 1,448
  0.07% of the heap (28.69% cumulative)
  0.18% of unreported (77.95% cumulative)
  Allocated at {
    #01: replace_malloc(unsigned long) (DMD.cpp:1267, in libmozglue.dylib)
    #02: moz_xmalloc (mozalloc.cpp:71, in libmozglue.dylib)
    #03: mozilla::dom::FragmentOrElement::Children() (mozalloc.h:136, in XUL)

We should just report mChildrenList and maybe some other things.

While here, I should probably report the memory of the array inside the nsContentList...

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

In theory we could report mChildrenList to be owned by the slot if list's refcnt is just 1.

Comment 2

[Boris Zbarsky [:bzbarsky]]

I think we can report it as owned by the slot always.  Nothing else is reporting it.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1487237. Add some content lists stored in DOM slots to memory reporting. r=smaug

This reports the memory as part of element-nodes, but I think that's OK for
now.  If we want to, we can try to add more nsWindowSizes buckets for this stuff.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 9005780 [details]
Bug 1487237.  Add some content lists stored in DOM slots to memory reporting.  r=smaug

Olli Pettay [:smaug] has approved the revision.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d718fc7c16e6
Add some content lists stored in DOM slots to memory reporting.  r=smaug

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d718fc7c16e6