1487258 - load enterprise roots on a background thread

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

At startup, if the enterprise roots pref is enabled, we do the finding/loading on the main thread. Since this can involve certificate verification, it should probably be done on a background thread. Luckily we already have a handy background thread that we use to load the loadable roots module, so this should be a straightforward change.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: bug 1487258 - load enterprise roots on a background at startup r?jcj

Loading enterprise roots could potentially take a while, so we certainly
shouldn't do it on the main thread at startup. Note that this doesn't address
the case where a user enables the feature while Firefox is running. This isn't
great but since it's an about:config preference rather than a first-class
preference exposed in about:preferences, we can probably get away with it for
now.

Comment 2

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 9005284 [details]
bug 1487258 - load enterprise roots on a background at startup r?jcj

J.C. Jones [:jcj] (he/him) has approved the revision.

Comment 3

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Thanks! https://treeherder.mozilla.org/#/jobs?repo=try&revision=cfc6701931c5abd98348fffcd54f733c774a8789

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3a800dfc6ad8
load enterprise roots on a background at startup r=jcj

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3a800dfc6ad8