Closed Bug 1487271 Opened Last year Closed Last year

Add telemetry about ForgetSkippable frequency

Categories

(Core :: XPCOM, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: smaug, Assigned: smaug)

Details

Attachments

(4 files)

I'd like to know how often, on average, ForgetSkippable is called, say, per minute.
Priority: -- → P3
Something like this. I was thinking either frequency or time between calls, but frequency is easier to understand, I think. And we should lower that to save power usage.
Assignee: nobody → bugs
Attachment #9005491 - Flags: review?(continuation)
Comment on attachment 9005491 [details] [diff] [review]
forget_skippable_telemetry.diff

Review of attachment 9005491 [details] [diff] [review]:
-----------------------------------------------------------------

Please also remember to do the data collection request thing.

::: toolkit/components/telemetry/Histograms.json
@@ +535,5 @@
> +    "kind": "linear",
> +    "high": 500,
> +    "n_buckets": 100,
> +    "bug_numbers": [1487271],
> +    "description": "Number of forget skippables occured during a minute"

nit: "occurred".
Attachment #9005491 - Flags: review?(continuation) → review+
Attached file frequency_probes.txt
Attachment #9005515 - Flags: review?(chutten)
Comment on attachment 9005515 [details]
frequency_probes.txt

DATA COLLECTION REVIEW RESPONSE:

    Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Standard telemetry mechanisms apply.

    Is there a control mechanism that allows the user to turn the data collection on and off? 

Standard telemetry mechanisms apply.

    If the request is for permanent data collection, is there someone who will monitor the data over time?**

Yes, :smaug

    Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1

    Is the data collection request for default-on or default-off?

Default on (though from the code it appears to be pre-release only?)

    Does the instrumentation include the addition of any new identifiers?

No.

    Is the data collection covered by the existing Firefox privacy notice? 

Yes.

    Does there need to be a check-in in the future to determine whether to renew the data?

Nope, permanent collection.

---
Result: datareview+ once :smaug adds his (or someone else who will watch over this probe's) individual email address to the alerts_email field (never-expiring probes should have an individual's email address in that list. Having a mailing list too is great as well), and after clarifying that either you're okay with collecting on pre-release only or you intend to change the definition to add "releaseChannelCollection": "opt-out".
Flags: needinfo?(bugs)
Attachment #9005515 - Flags: review?(chutten) → review+
For now pre-release is enough, I think.
Flags: needinfo?(bugs)
Attached patch +email addressSplinter Review
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c57165730494
Add telemetry about ForgetSkippable frequency, r=mccr8,chutten
Pushed by apavel@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e94ee8be8c14
Add telemetry about ForgetSkippable frequency, r=mccr8,chutten
https://hg.mozilla.org/mozilla-central/rev/e94ee8be8c14
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.