Closed Bug 1487305 Opened Last year Closed Last year

Make HTMLEditor::IsInLink as static method

Categories

(Core :: DOM: Editor, enhancement, P3)

Product:
Core
Component:
DOM: Editor
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: m_kato, Assigned: m_kato)

Details

Attachments

(1 file)

Bug 1487305 - Make HTMLEditor::IsInLink as static method. r?masayuki
46 bytes, text/x-phabricator-request
masayuki
: review+
Details | Review 
reducing QI and add refs.
Now HTMLEditor::IsInLink returns boolean and nsINode if returning true.

I would like to return Element instead of boolean for reducing refcounting
and QI like HTMLEditRules::IsInListItem.
Comment on attachment 9005111 [details]
Bug 1487305 - Make HTMLEditor::IsInLink as static method. r?masayuki

Masayuki Nakano [:masayuki] (JST, +0900) has approved the revision.
Attachment #9005111 - Flags: review+
Pushed by m_kato@ga2.so-net.ne.jp:
https://hg.mozilla.org/integration/mozilla-inbound/rev/78b5292850ee
Make HTMLEditor::IsInLink as static method. r=masayuki
https://hg.mozilla.org/mozilla-central/rev/78b5292850ee
Status: NEW → RESOLVED
Closed: Last year
status-firefox63: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.