1487345 - Support CMYK images

Status: RESOLVED DUPLICATE of bug 1989218

(Core :: Graphics: ImageLib, defect, P3)

Description

[u623372]

Attachment: Bildschirmfoto 2018-08-30 um 12.32.43.png

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.106 Safari/537.36

Steps to reproduce:

Open CMYK JPEG in Firefox (Mac OSX 10.12.6)


Actual results:

The image appears different to the original (colors are wrong).
See screenshot: left is the original image, on the right side you see the same image in browser


Expected results:

Firefox v61.0.2 should display the correct colors

Comment 1

[ovidiu boca[:Ovidiu]]

I tested this issue on Mac OS X 10.12 with FF Nightly 63.0a1(2018-08-02) and I can't reproduce it. 

Please download Firefox Nightly from here: https://nightly.mozilla.org/ and retest the problem.

If the issue is still reproducible please test it in safe mode, here is a link that can help you:
https://support.mozilla.org/en-US/kb/troubleshoot-firefox-issues-using-safe-mode

Please upload the exact photo that you are using to this bug report.

Comment 2

[u623372]

Attachment: flower-purple-lical-blosso_CMYK.jpeg

Comment 3

[u623372]

I can reproduce the bug on Mac OS X 10.12.6 Nighlty 63.0a1 (2018-09-03) (64-Bit)

Comment 4

[u623372]

The bug is probably related to https://bugzilla.mozilla.org/show_bug.cgi?id=44781

Comment 5

[ovidiu boca[:Ovidiu]]

Thanks for the attachment, I can reproduce it on the latest Nightly 63.0a1(2018-08-02) and also Release version 61 with Mac OS X 10.12 and Windows 10 x64.

Comment 6

[Andrew Osmond [:aosmond] (he/him)]

The image is tagged with an ICC profile but we don't support using color management with it right now, so it doesn't apply the transformation:

https://searchfox.org/mozilla-central/rev/5a18fb5aeeec99f1ca1c36a697082c221189a3b9/image/decoders/nsJPEGDecoder.cpp#309

Comment 7

[Jeff Muizelaar [:jrmuizel]]

To improve on the quality of CMYK JPEGs we could use the kCGColorSpaceGenericCMYK color space on macOS. This will let us match how Safari loads them. On other OSs we could ship "Web Coated (SWOP) v2" which is the default CMYK space used in Photoshop and seems to be redistributable from Adobe.

Comment 9

[Grisu]

Attachment: grafik.png

CMYK image test still shown with wrong color cyan/green instead of blue and FF 93.0.
Correct colors when using Edge.
https://chromachecker.com/info/en/page/webbrowser

I have set
https://chromachecker.com/info/en/page/webbrowser = true
gfx.color_management.mode = 1

using icc profile from Eizo monitor with HW-calibration.

Comment 10

[Grisu]

Comment on attachment 9245792 [details]
grafik.png

CMYK image test still shown with wrong color cyan/green instead of blue and FF 93.0.
Correct colors when using Edge.
https://chromachecker.com/info/en/page/webbrowser

I have set
gfx.color_management.enablev4 = true
gfx.color_management.mode = 1

using icc profile from Eizo monitor with HW-calibration.

Comment 11

[Takanori MATSUURA]

CMYK support seems to have been added by bug 1706144.
Why doesn't it work?

Comment 12

[Timothy Nikkel (:tnikkel)]

I'm not sure, it's a bug that needs to be investigated to understand what is going on.

Comment 13

[Kagami Rosylight [:saschanaz] (they/them)]

Bug 1989218 is now adding CMYK pipeline and then bug 1943799 will use it for JPEG. Let's track this there.