Closed
Bug 1487357
Opened 6 years ago
Closed 6 years ago
Alarm icons aren't displayed in calendar views anymore
Categories
(Calendar :: Calendar Frontend, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
6.5
People
(Reporter: MakeMyDay, Assigned: Paenglab)
References
Details
(Keywords: regression)
Attachments
(1 file)
|
1.30 KB,
patch
|
MakeMyDay
:
review+
|
Details | Diff | Splinter Review |
STR: 1. Create an event with an alarm 2. Go to the calendar view Expected: The alarm icon should be visible at the right / right upper corner of the event box in the calendar view Observed: Icon is not displayed. The box with the icon is rendered, so it's probably a css issue. The same works in 60b11, so it must be a regression of one of the recent changes in 6.5 / TB63.
|
Assignee | |
Comment 1•6 years ago
|
||
It seems this is caused by the <resources> removal. Added the stylesheet to calendar-views.xul and it works again.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9005239 -
Flags: review?(makemyday)
|
Reporter | |
Comment 2•6 years ago
|
||
Comment on attachment 9005239 [details] [diff] [review] alarm-icons.patch Review of attachment 9005239 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, looks good again.
Attachment #9005239 -
Flags: review?(makemyday) → review+
|
|
Assignee | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by mozilla@jorgk.com: https://hg.mozilla.org/comm-central/rev/38bde34f2562 Bug 1474123 follow-up: Fix missing alarm icons by adding the calendar-alarms.css stylesheet to calendar-views.xul. r=MakeMyDay
|
||
Comment 4•6 years ago
|
||
Please try to express in the commit message what the bug was about. "Added +1 in calculation is xxx.cpp" wouldn't be a good commit message.
Target Milestone: --- → 6.5
You need to log in
before you can comment on or make changes to this bug.
Description
•