1487376 - JavaScript error: resource://gre/modules/sessionstore/SessionHistory.jsm, line 90: TypeError: shistoryInternal.GetTransactionAtIndex is not a function

Status: RESOLVED INCOMPLETE

(Core :: DOM: Navigation, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Seen in a try push for a recent web-platform-test sync:

https://treeherder.mozilla.org/logviewer.html#?job_id=196610706&repo=try&lineNumber=20303

JavaScript error: resource://gre/modules/sessionstore/SessionHistory.jsm, line 90: TypeError: shistoryInternal.GetTransactionAtIndex is not a function

It looks like this is a regression from the patch on bug 1486358.

Comment 1

[James Graham [:jgraham]]

I'm 83% sure that the problem is that the original patch didn't play well with artifact builds for some reason, because I rebased and tried another try run with a non-artifact build and it seems to work OK.

Comment 2

[Nicholas Nethercote [inactive]]

I suspect James is correct. Bug 1486358 added this declaration to nsISHistoryInternal.idl:

> nsISHTransaction GetTransactionAtIndex(in int32_t aIndex);

So things should be ok. Furthermore, that error is something that you'd expect to be consistently failing across the whole tree.

Comment 3

[Nicholas Nethercote [inactive]]

This appears to have been a transient problem. (Please reopen if you see it again.)