1487385 - React unique "key" prop warning every time the toolbox is opened

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

I get this warning every time I open the toolbox:

"Warning: Each child in an array or iterator should have a unique "key" prop.

Check the render method of `ToolboxTabs`. See https://fb.me/react-warning-keys for more information.
    in MenuItem (created by ToolboxTabs)
    in ToolboxTabs (created by ToolboxToolbar)
    in div (created by ToolboxToolbar)
    in ToolboxToolbar (created by ToolboxController)
    in ToolboxController"

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1487385 - Add key prop to MenuItem call

Fixes this warning every time the toolbox is opened:
I get this warning every time I open the toolbox:

"Warning: Each child in an array or iterator should have a unique "key" prop.

Check the render method of `ToolboxTabs`. See https://fb.me/react-warning-keys for more information.
    in MenuItem (created by ToolboxTabs)
    in ToolboxTabs (created by ToolboxToolbar)
    in div (created by ToolboxToolbar)
    in ToolboxToolbar (created by ToolboxController)
    in ToolboxController"

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Comment on attachment 9005189 [details]
Bug 1487385 - Add key prop to MenuItem call

Nicolas Chevobbe [:nchevobbe] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d85d49538117
Add key prop to MenuItem call r=nchevobbe

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/d85d49538117