Closed Bug 1487385 Opened Last year Closed Last year

React unique "key" prop warning every time the toolbox is opened

Categories

(DevTools :: Inspector, defect, P2)

57 Branch
defect

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: miker, Assigned: miker)

Details

Attachments

(1 file)

I get this warning every time I open the toolbox:

"Warning: Each child in an array or iterator should have a unique "key" prop.

Check the render method of `ToolboxTabs`. See https://fb.me/react-warning-keys for more information.
    in MenuItem (created by ToolboxTabs)
    in ToolboxTabs (created by ToolboxToolbar)
    in div (created by ToolboxToolbar)
    in ToolboxToolbar (created by ToolboxController)
    in ToolboxController"
Fixes this warning every time the toolbox is opened:
I get this warning every time I open the toolbox:

"Warning: Each child in an array or iterator should have a unique "key" prop.

Check the render method of `ToolboxTabs`. See https://fb.me/react-warning-keys for more information.
    in MenuItem (created by ToolboxTabs)
    in ToolboxTabs (created by ToolboxToolbar)
    in div (created by ToolboxToolbar)
    in ToolboxToolbar (created by ToolboxController)
    in ToolboxController"
Comment on attachment 9005189 [details]
Bug 1487385 - Add key prop to MenuItem call

Nicolas Chevobbe [:nchevobbe] has approved the revision.
Attachment #9005189 - Flags: review+
Pushed by mratcliffe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d85d49538117
Add key prop to MenuItem call r=nchevobbe
https://hg.mozilla.org/mozilla-central/rev/d85d49538117
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
Attachment #9005189 - Flags: review?(nchevobbe)
You need to log in before you can comment on or make changes to this bug.