1487397 - No hover styling on trees

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P1)

Description

[M8R-p7]

Attachment: Screenshot comparison

(Tested on Win7 + Win10, 63.0b1 + 64.0a1)

Visible differences:
- Tree item styling (active / hover)
- Search box padding / border
- Button styling

When DevEdition updated to 63.0b1 I lost hover styles on tree items in sidebars. While looking for a cause, I found that all the default sidebars' 'search' boxes lacked padding and a grey border, and the History Sidebar's 'View' button lacked button styling.

The necessary styles are defined in `global/in-content/common.css`, but this doesn't appear to be being applied to sidebars. A screenshot is included, showing the existing style and with manual application of 'common.css' rules. The 'Privacy Notice' item is being hovered in both shots.

Comment 1

[Alice0775 White]

Affected to Library window and Edit this bookmark panel.

:ntim, could you please look into this?

Comment 2

[Alice0775 White]

Page Info window also affected.

Comment 3

[Tim Nguyen :ntim]

Changing platform to Windows, because Linux and MacOS never had any hover states.

I'm not sure what color we can use here for hover, but the spec seems to use a semi-transparent gray.

https://firefoxux.github.io/people/shorlander/photon/Mockups/windows-10.html

Comment 4

[Mike de Boer [:mikedeboer]]

Assigning this bug to you, Tim, since this bug is tracked for 63.

Comment 5

[Mike de Boer [:mikedeboer]]

Feel free to ask Dão for pointers on the hover color!

Comment 6

[Tim Nguyen :ntim]

Attachment: Bug 1487397 - Add hover styling on trees on Windows default theme. r?dao

Comment 7

[Dão Gottwald [:dao]]

Comment on attachment 9008856 [details]
Bug 1487397 - Add hover styling on trees on Windows default theme. r?dao

Dão Gottwald [::dao] has approved the revision.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d073607e0ffa
Add hover styling on trees on Windows default theme. r=dao

Comment 9

[Tim Nguyen :ntim]

Comment on attachment 9008856 [details]
Bug 1487397 - Add hover styling on trees on Windows default theme. r?dao

Approval Request Comment
[Feature/Bug causing the regression]: bug 1469287
[User impact if declined]: no hover styling on trees on Windows default theme
[Is this code covered by automated tests?]: no
[Has the fix been verified in Nightly?]: not yet
[Needs manual test from QE? If yes, steps to reproduce]: 
[List of other uplifts needed for the feature/fix]: none
[Is the change risky?]: low risk
[Why is the change risky/not risky?]: small css patch
[String changes made/needed]: none

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

I'd like it to be verified on nightly before the uplift. Brindusa could you check that once it has landed? Thanks

Comment 11

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/d073607e0ffa

Comment 12

[Cristian Fogel [:cfogel]]

Managed to reproduce using DevEd.63.0b7, 63.0b6, 63.0b7 on win10.

Can confirm the issue is no longer present on 64.0a1 on both win10 and win7. 
The hover color is set to gray for both light/dark themes.
Search box and scrollbars have on-hover effects as well.

Comment 13

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9008856 [details]
Bug 1487397 - Add hover styling on trees on Windows default theme. r?dao

Uplift approved for 63 beta 8, thanks.

Comment 14

[M8R-p7]

Reporter confirming hover styling on trees looks as expected in Nightly 2018-09-19, thank you. This bug became narrower than the original description - should I file an new bug (or clone?) for the search fields and buttons missing base UI styles?

Comment 15

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/releases/mozilla-beta/rev/10bb8728016a

Comment 16

[Cristian Fogel [:cfogel]]

Verified with 63.0b8 on both Win10 and Win7.