1487404 - gMainPane._rebuildView does multiple appendChild calls which is slow

Status: RESOLVED FIXED

(Firefox :: Settings UI, enhancement, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: slow profile, search for _rebuildView

See attached profiles.

_rebuildView calls connectAndAppendToList for each item. By factoring out the append operation we can use a documentFragment and append all children at one time.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: fast profile, search for _rebuildView

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Sounds like an easy perf win for about:preferences. Setting to P3 for Preferences, but throwing into the fxperf triage.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: fast profile, search for _rebuildView

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1487404 - Coalesce multiple appendChild calls to one appendChild call when building the application handlers list. r?mconley

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 9005258 [details]
Bug 1487404 - Coalesce multiple appendChild calls to one appendChild call when building the application handlers list. r?mconley

Mike Conley (:mconley) (:⚙️) has approved the revision.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c9eebf9240e5
Coalesce multiple appendChild calls to one appendChild call when building the application handlers list. r=mconley

Comment 7

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c9eebf9240e5