Closed Bug 1487431 Opened 2 years ago Closed 2 years ago
Tests in dom/media/mediasource/test/test
_Frame Selection _mp4 .html are permanently failing .
46 bytes, text/x-phabricator-request
|Details | Review|
A typo was causing the tests at https://searchfox.org/mozilla-central/source/dom/media/mediasource/test/test_FrameSelection_mp4.html#42 to be not run. Fixing that shows that the test is permanently failing on all platforms
:jib, could you please have a look and see if the changes from Bug 1462990 caused this to start failing?
Priority: -- → P3
Sorry do you give me a link? I couldn't immediately find the failures you're referring to. The test passes fine locally for me on OSX.
Flags: needinfo?(jib) → needinfo?(dtownsend)
(In reply to Jan-Ivar Bruaroey [:jib] (needinfo? me) from comment #2) > Sorry do you give me a link? I couldn't immediately find the failures you're > referring to. > > The test passes fine locally for me on OSX. Did you first correct the typo, (or remove the comments if you're on a very up to date tree?) Here is a link to failures: https://firstname.lastname@example.org&selectedJob=196545785
Ah! I didn't even see the typo! s/if/is/ got it! To Dan, that typo predates my changes, goes back to when the test was created in 20166: https://searchfox.org/mozilla-central/rev/674c5d9778e538054d4f9abadcfd22d7f475f5ae/dom/media/mediasource/test/test_FrameSelection_mp4.html#64-65 So those two tests have never run successfully. Bryce, thoughts?
Oh wait, should probably be videoWidth and videoHeight. Nevermind. :P
Assignee: nobody → jib
Rank: 25 → 15
Priority: P3 → P2
Comment on attachment 9005726 [details] Fix typo in mediasource test_FrameSelection_mp4.html to make last two tests work. Bryce Seager van Dyk (:bryce) has approved the revision.
Attachment #9005726 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/bd82753f481a Fix typo in mediasource test_FrameSelection_mp4.html to make last two tests work. r=bryce
You need to log in before you can comment on or make changes to this bug.