Closed
Bug 1487431
Opened 2 years ago
Closed 2 years ago
Tests in dom/media/mediasource/test/test_FrameSelection_mp4.html are permanently failing.
Categories
(Core :: Audio/Video, defect, P2)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: mossop, Assigned: jib)
Details
Attachments
(1 file, 1 obsolete file)
A typo was causing the tests at https://searchfox.org/mozilla-central/source/dom/media/mediasource/test/test_FrameSelection_mp4.html#42 to be not run. Fixing that shows that the test is permanently failing on all platforms
Comment 1•2 years ago
|
||
:jib, could you please have a look and see if the changes from Bug 1462990 caused this to start failing?
Rank: 25
Flags: needinfo?(jib)
Priority: -- → P3
Assignee | ||
Comment 2•2 years ago
|
||
Sorry do you give me a link? I couldn't immediately find the failures you're referring to. The test passes fine locally for me on OSX.
Flags: needinfo?(jib) → needinfo?(dtownsend)
Reporter | ||
Comment 3•2 years ago
|
||
(In reply to Jan-Ivar Bruaroey [:jib] (needinfo? me) from comment #2) > Sorry do you give me a link? I couldn't immediately find the failures you're > referring to. > > The test passes fine locally for me on OSX. Did you first correct the typo, (or remove the comments if you're on a very up to date tree?) Here is a link to failures: https://treeherder.mozilla.org/#/jobs?repo=try&author=dtownsend@mozilla.com&selectedJob=196545785
Flags: needinfo?(dtownsend)
Assignee | ||
Comment 4•2 years ago
|
||
Ah! I didn't even see the typo! s/if/is/ got it! To Dan, that typo predates my changes, goes back to when the test was created in 20166: https://searchfox.org/mozilla-central/rev/674c5d9778e538054d4f9abadcfd22d7f475f5ae/dom/media/mediasource/test/test_FrameSelection_mp4.html#64-65 So those two tests have never run successfully. Bryce, thoughts?
Flags: needinfo?(bvandyk)
Assignee | ||
Comment 5•2 years ago
|
||
Oh wait, should probably be videoWidth and videoHeight. Nevermind. :P
Flags: needinfo?(bvandyk)
Assignee | ||
Updated•2 years ago
|
Assignee: nobody → jib
Rank: 25 → 15
Priority: P3 → P2
Assignee | ||
Comment 6•2 years ago
|
||
Comment 7•2 years ago
|
||
Comment on attachment 9005726 [details]
Fix typo in mediasource test_FrameSelection_mp4.html to make last two tests work.
Bryce Seager van Dyk (:bryce) has approved the revision.
Attachment #9005726 -
Flags: review+
Assignee | ||
Comment 8•2 years ago
|
||
Pushed by jbruaroey@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bd82753f481a Fix typo in mediasource test_FrameSelection_mp4.html to make last two tests work. r=bryce
Assignee | ||
Updated•2 years ago
|
Attachment #9005734 -
Attachment is obsolete: true
Comment 10•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bd82753f481a
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Updated•2 years ago
|
Attachment #9005734 -
Attachment is obsolete: false
Updated•2 years ago
|
Attachment #9005734 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•