1487431 - Tests in dom/media/mediasource/test/test_FrameSelection_mp4.html are permanently failing.

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Dave Townsend [:mossop]]

A typo was causing the tests at https://searchfox.org/mozilla-central/source/dom/media/mediasource/test/test_FrameSelection_mp4.html#42 to be not run. Fixing that shows that the test is permanently failing on all platforms

Comment 1

[Dan Minor [:dminor]]

:jib, could you please have a look and see if the changes from Bug 1462990 caused this to start failing?

Comment 2

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Sorry do you give me a link? I couldn't immediately find the failures you're referring to.

The test passes fine locally for me on OSX.

Comment 3

[Dave Townsend [:mossop]]

(In reply to Jan-Ivar Bruaroey [:jib] (needinfo? me) from comment #2)
> Sorry do you give me a link? I couldn't immediately find the failures you're
> referring to.
> 
> The test passes fine locally for me on OSX.

Did you first correct the typo, (or remove the comments if you're on a very up to date tree?)

Here is a link to failures: https://treeherder.mozilla.org/#/jobs?repo=try&author=[e-mail]&selectedJob=196545785

Comment 4

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Ah! I didn't even see the typo! s/if/is/ got it!

To Dan, that typo predates my changes, goes back to when the test was created in 20166:

https://searchfox.org/mozilla-central/rev/674c5d9778e538054d4f9abadcfd22d7f475f5ae/dom/media/mediasource/test/test_FrameSelection_mp4.html#64-65

So those two tests have never run successfully. Bryce, thoughts?

Comment 5

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Oh wait, should probably be videoWidth and videoHeight. Nevermind. :P

Comment 6

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Fix typo in mediasource test_FrameSelection_mp4.html to make last two tests work.

Comment 7

[Bryce Seager van Dyk [:bryce] (he/him) - Not reading bugmail]

Comment on attachment 9005726 [details]
Fix typo in mediasource test_FrameSelection_mp4.html to make last two tests work.

Bryce Seager van Dyk (:bryce) has approved the revision.

Comment 8

[Jan-Ivar Bruaroey [:jib] (needinfo? me)]

Attachment: Bug 1487431 - Fix typo in mediasource test_FrameSelection_mp4.html to make last two tests work. r?bryce

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bd82753f481a
Fix typo in mediasource test_FrameSelection_mp4.html to make last two tests work. r=bryce

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/bd82753f481a