Closed Bug 1487437 Opened Last year Closed Last year

When a site changes its favicon after load we show the space for a pending icon briefly in addition to any existing icon.

Categories

(Firefox :: Tabbed Browser, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 63
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox61 --- unaffected
firefox62 --- unaffected
firefox63 + fixed

People

(Reporter: mossop, Assigned: mossop)

References

Details

(Keywords: regression)

Attachments

(1 file)

We should only set the pendingicon attribute if the throbber is showing I guess.
This stops us from showing a pending space when an icon is added after loading is
complete causing us to shift the title when both pending and previous icon are
shown.
Comment on attachment 9005253 [details]
Bug 1487437: Only show a space for a pending icon if it started loading while the throbber was showing. r=dao.

Dão Gottwald [::dao] has approved the revision.
Attachment #9005253 - Flags: review+
Pushed by dtownsend@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8ce5007ce60f
Only show a space for a pending icon if it started loading while the throbber was showing. r=dao.
https://hg.mozilla.org/mozilla-central/rev/8ce5007ce60f
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.