Closed Bug 1487449 Opened 2 years ago Closed 2 years ago

stop macro redefinition warning spam for Windows macros

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox63 fixed)

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

This warning spam happens particularly with WebRTC, but I can see it
happening for any third-party software whose use of WINVER and friends
conflicts with our own.  Let's just change mozilla-config.h to avoid
defining these macros if they're already defined via the command line.
This feels like a big, but effective, hammer.
Attachment #9005241 - Flags: review?(core-build-config-reviews)
Comment on attachment 9005241 [details] [diff] [review]
stop macro redefinition warning spam for Windows macros

Review of attachment 9005241 [details] [diff] [review]:
-----------------------------------------------------------------

Ideally we wouldn't pass in different values from different places, but I'm not sure it's worth anyone's time to actually track all of those down and fix them.
Attachment #9005241 - Flags: review?(core-build-config-reviews) → review+
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/89e2f1795be7
stop macro redefinition warning spam for Windows macros; r=ted.mielczarek
https://hg.mozilla.org/mozilla-central/rev/89e2f1795be7
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.