Closed Bug 1487465 Opened Last year Closed 6 months ago
Pass causes 6s hang in content
STR: - Install LastPass extension (and log in) - Open https://dxr.mozilla.org/mozilla-central/search?q=actor%20perf - Click on a folder (like `/ lib /` in the first result) ER: Menu opens instantly AR: Menu opens after 6 second hang Profile: https://perfht.ml/2oomMEz High level analysis: - mouseup event triggers `L</LPSiteNotification` (which seems to be called twice) - `getText` (which is called by `getUsername`) calls `Symbol.split` many times (see Stack Chart) - `Symbol.split` does regexp work and substr matching
This is an issue in the lastpass extension.
Component: General → Add-ons
Product: WebExtensions → Tech Evangelism
Harald, can you check whether this is faster in Chrome? LastPass should presumably be hitting the same code path there. If they have a faster implementation of String.prototype.split on regex, there's a Spidermonkey bug here, otherwise it's really just something for LastPass to fix.
(In reply to Markus Stange [:mstange] from comment #2) > If they have a faster > implementation of String.prototype.split on regex, there's a Spidermonkey > bug here, Which might be bug 1437914.
Chrome with LastPass no significant delay. Attached a Chrome trace recorded for LastPass on DXR, using the "rendering & input latency" preset.
Depends on: 1428972
Whiteboard: [qf] → [qf:p1:f67]
(In reply to Markus Stange [:mstange] from comment #3) > might be bug 1437914. (In reply to :Harald Kirschner :digitarald from comment #4) > Chrome with LastPass no significant delay. (OK -- then this isn't bug 1437914, since that one is equivalently bad between Firefox & Chrome, aside from the fact that Chrome runs the regex less often in the original testcase there.
Whiteboard: [qf:p1:f67] → [qf:p2:responsiveness]
Component: Add-ons → General
Product: Tech Evangelism → WebExtensions
Component: General → XPConnect
Product: WebExtensions → Core
Component: XPConnect → Developer Outreach
Product: Core → WebExtensions
Status: NEW → RESOLVED
Closed: 6 months ago
Priority: -- → P5
Resolution: --- → FIXED
Whiteboard: [qf:p2:responsiveness] → [qf:p2:responsiveness] triaged
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.