browser.xhtml: lightweight themes don't quite work (lwtheme and lwthemetextcolor attribute changes only work with XUL Documents)

RESOLVED FIXED in Firefox 63

Status

()

RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 63
Points:
---
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 months ago
This can be tested by going to about:addons and applying a theme (customize mode doesn't seem to work and I'm guessing that's related to these issues).

See: https://searchfox.org/mozilla-central/source/dom/xul/nsXULElement.cpp#869-872,893-899.

Relevant stuff on XULDocument that can hopefully be hoisted up to Document or to top-level windows:

mDocLWTheme
virtual nsIDocument::DocumentTheme GetDocumentLWTheme() override;
virtual nsIDocument::DocumentTheme ThreadSafeGetDocumentLWTheme() const override;
void ResetDocumentLWTheme()
Flags: qe-verify-
(Assignee)

Comment 1

5 months ago
Error when opening Customize Mode:

CustomizeMode: Error entering customize mode TypeError: "lwthemeIcon is null, can't access property "style" of it"
	_updateLWThemeButtonIcon resource:///modules/CustomizeMode.jsm:170:5
	enter resource:///modules/CustomizeMode.jsm:346:7
	enter resource:///modules/CustomizeMode.jsm:266:6
	setTab resource:///modules/CustomizeMode.jsm:203:7
	enter resource:///modules/CustomizeMode.jsm:237:7
	oncommand chrome://browser/content/browser.xhtml:1:1
(Assignee)

Comment 2

5 months ago
Note: this requires `mk_add_options 'export MOZ_BROWSER_XHTML=1'` to reproduce.
(Assignee)

Updated

5 months ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
(Assignee)

Comment 3

5 months ago
Created attachment 9005459 [details]
Bug 1487476 - Expose lightweight themes as chrome-only features on nsIDocument instead of XULDocument;r=smaug
Comment on attachment 9005459 [details]
Bug 1487476 - Expose lightweight themes as chrome-only features on nsIDocument instead of XULDocument;r=smaug

Olli Pettay [:smaug] has approved the revision.
Attachment #9005459 - Flags: review+
(Assignee)

Updated

5 months ago
See Also: → bug 1487568

Comment 5

5 months ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/414403195a4e
Expose lightweight themes as chrome-only features on nsIDocument instead of XULDocument;r=smaug

Comment 6

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/414403195a4e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.