Closed Bug 1487483 Opened 2 years ago Closed 2 years ago

Tidy adding store buffer entries

Categories

(Core :: JavaScript: GC, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(1 file)

There are a couple of places when we create an edge X -> Y where check whether Y is in the nursery and then get the store buffer for the runtime to add it to.

We can combine these by calling the Cell::storeBuffer() method which gives you the store buffer to use for incoming edges to a cell if it is in the nursery.
It turned out that weren't that many places where we do this.
Attachment #9005288 - Flags: review?(sphink)
Attachment #9005288 - Flags: review?(sphink) → review+
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e51673acfbef
Tidy adding store buffer entries when creating an edge to a cell in the nursery r=sfink
https://hg.mozilla.org/mozilla-central/rev/e51673acfbef
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.