Theme is not removed when click [Remove] button

VERIFIED FIXED in Firefox 63

Status

()

VERIFIED FIXED
7 months ago
6 months ago

People

(Reporter: alice0775, Assigned: kmag)

Tracking

({regression, ux-mode-error})

62 Branch
mozilla64
x86_64
Windows 10
regression, ux-mode-error
Points:
---

Firefox Tracking Flags

(firefox-esr52 unaffected, firefox-esr60 unaffected, firefox61 unaffected, firefox62+ wontfix, firefox63 verified, firefox64 verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

7 months ago
Reproducible : always


Steps To Reproduce:
1. Install Theme
2. Open Add-on Manager
3. Choose "Themes"
4. Click [Remove] button of the installed theme of step1.

Actual Results:
Theme is not removed. But disabled.

Expected results:
Theme should be removed.
(Reporter)

Comment 1

7 months ago
[Tracking Requested - why for this release]: Cannot remove theme.

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=72189b6ec0f192d7c26abaa8d449af3b94a11327&tochange=510b02c8eb4c30437fd06058a6d46b827f0f1d78

Regressed by: 510b02c8eb4c	Kris Maglione — Bug 1467695: Wait for async disable operations to finish when calling addonChanged listeners. r=aswan


:kmag,
Your patch causes the regression, Could you please look into this?
Blocks: 1467695
tracking-firefox62: --- → ?
tracking-firefox63: --- → ?
Flags: needinfo?(kmaglione+bmo)
This sounds less than great. Not going to block the release on it, but I'd definitely consider a patch for a dot release.
tracking-firefox62: ? → +
tracking-firefox63: ? → +
Comment on attachment 9007096 [details]
Bug 1487525: Don't reset pending uninstall attribute when disabling theme. r=aswan

Andrew Swan [:aswan] has approved the revision.
Attachment #9007096 - Flags: review+
Kris, is this ready to land?
Assignee: nobody → kmaglione+bmo
(Assignee)

Comment 6

6 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/a4e3bfaefca5764612e436d1e900ca9fa0620bf8
Bug 1487525: Don't reset pending uninstall attribute when disabling theme. r=aswan
Backed out changeset a4e3bfaefca5 (bug 1487525) for xpcshell failures on xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_LightweightThemeManager.js. CLOSED TREE 

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=198923920&repo=mozilla-inbound&lineNumber=10643

INFO -  TEST-PASS | toolkit/components/extensions/test/xpcshell/test_ext_native_messaging.js | took 1640ms
20:06:36     INFO -  TEST-START | toolkit/components/extensions/test/xpcshell/test_ext_native_messaging_perf.js
20:06:40     INFO -  TEST-PASS | toolkit/components/extensions/test/xpcshell/test_ext_native_messaging_perf.js | took 3879ms
20:06:40     INFO -  TEST-START | toolkit/components/reputationservice/test/unit/test_app_rep.js
20:06:41     INFO -  TEST-PASS | toolkit/components/reputationservice/test/unit/test_app_rep.js | took 277ms
20:06:41     INFO -  TEST-START | toolkit/components/reputationservice/test/unit/test_app_rep_windows.js
20:06:41     INFO -  TEST-PASS | toolkit/components/reputationservice/test/unit/test_app_rep_windows.js | took 366ms
20:06:41     INFO -  TEST-START | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_LightweightThemeManager.js
20:06:42  WARNING -  TEST-UNEXPECTED-FAIL | xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_LightweightThemeManager.js | xpcshell return code: 0
20:06:42     INFO -  TEST-INFO took 688ms
20:06:42     INFO -  >>>>>>>
20:06:42     INFO -  PID 8700 | JavaScript strict warning: resource://testing-common/AddonTestUtils.jsm, line 310: ReferenceError: reference to undefined property "testScope"
20:06:42     INFO -  "CONSOLE_MESSAGE: (warn) [JavaScript Warning: "ReferenceError: reference to undefined property "testScope"" {file: "resource://testing-common/AddonTestUtils.jsm" line: 310}]"
20:06:42     INFO -  (xpcshell/head.js) | test MAIN run_test pending (1)
20:06:42     INFO -  (xpcshell/head.js) | test run_next_test 0 pending (2)
20:06:42     INFO -  (xpcshell/head.js) | test MAIN run_test finished (2)
20:06:42     INFO -  running event loop
20:06:42     INFO -  xpcshell.ini:toolkit/mozapps/extensions/test/xpcshell/test_LightweightThemeManager.js | Starting run_test
20:06:42     INFO -  (xpcshell/head.js) | test run_test pending (2)
20:06:42     INFO -  PID 8700 | 1536782801629	addons.manager	DEBUG	Application has been upgraded
20:06:42     INFO -  PID 8700 | 1536782801639	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/XPIProvider.jsm: ["XPIProvider", "XPIInternal"]
20:06:42     INFO -  PID 8700 | 1536782801641	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/LightweightThemeManager.jsm: ["LightweightThemeManager"]
20:06:42     INFO -  PID 8700 | 1536782801644	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/GMPProvider.jsm
20:06:42     INFO -  PID 8700 | 1536782801645	addons.manager	DEBUG	Loaded provider scope for resource://gre/modules/addons/PluginProvider.jsm
20:06:42     INFO -  PID 8700 | 1536782801645	addons.manager	DEBUG	Starting provider: XPIProvider
20:06:42     INFO -  PID 8700 | 1536782801646	addons.xpi	DEBUG	startup
20:06:42     INFO -  PID 8700 | 1536782801646	addons.xpi	WARN	List of valid built-in add-ons could not be parsed.: [Exception... "Component returned failure code: 0xc1f30001 (NS_ERROR_NOT_INITIALIZED) [nsIXPCComponents_Utils.readUTF8URI]"  nsresult: "0xc1f30001 (NS_ERROR_NOT_INITIALIZED)"  location: "JS frame :: resource://gre/modules/addons/XPIProvider.jsm :: startup :: line 2094"  data: no] Stack trace: startup()@resource://gre/modules/addons/XPIProvider.jsm:2094
20:06:42     INFO -  PID 8700 | callProvider()@resource://gre/modules/AddonManager.jsm:206
20:06:42     INFO -  PID 8700 | _startProvider()@resource://gre/modules/AddonManager.jsm:654
20:06:42     INFO -  PID 8700 | startup()@resource://gre/modules/AddonManager.jsm:807
20:06:42     INFO -  PID 8700 | startup()@resource://gre/modules/AddonManager.jsm:2814
20:06:42     INFO -  PID 8700 | observe()@jar:file:///Z:/task_1536781141/build/application/firefox/omni.ja!/components/addonManager.js:66

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed,busted,exception&classifiedState=unclassified&group_state=expanded&revision=a4e3bfaefca5764612e436d1e900ca9fa0620bf8

https://hg.mozilla.org/integration/mozilla-inbound/rev/8b3b7ee0fffbe93416ea6f2769366fa330f14556
(Assignee)

Comment 8

6 months ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/0d8d4803236e5ee1300d0c95f73c5e57f3ade2dc
Bug 1487525: Don't reset pending uninstall attribute when disabling theme. r=aswan
(Assignee)

Updated

6 months ago
Flags: needinfo?(kmaglione+bmo)

Comment 9

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/0d8d4803236e
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Kris, could you request a beta uplift when you get a chance? Thanks
Flags: needinfo?(kmaglione+bmo)
status-firefox62: affected → wontfix
I have managed to reproduce this issue using Firefox 63.0a1 (BuildId:20180830220110).

This is verified fixed using Firefox 64.0a1 (BuildId:20180920220102) on Windows 10 64bit, macOS 10.9.5 and Ubuntu 16.04 64bit.
Status: RESOLVED → VERIFIED
status-firefox64: fixed → verified
(Assignee)

Comment 12

6 months ago
Comment on attachment 9007096 [details]
Bug 1487525: Don't reset pending uninstall attribute when disabling theme. r=aswan

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1467695
[User impact if declined]: This bug prevents users from uninstalling the currently active theme without taking extra steps.
[Is this code covered by automated tests?]: Yes.
[Has the fix been verified in Nightly?]: Yes.
[Needs manual test from QE? If yes, steps to reproduce]: N/A
[List of other uplifts needed for the feature/fix]: None.
[Is the change risky?]: No.
[Why is the change risky/not risky?]: It's a fairly simple change to connect two asynchronous operations which should have been connected to begin with.
[String changes made/needed]: None.
Flags: needinfo?(kmaglione+bmo)
Attachment #9007096 - Flags: approval-mozilla-beta?
Comment on attachment 9007096 [details]
Bug 1487525: Don't reset pending uninstall attribute when disabling theme. r=aswan

Fix for a tracked 63 regression, uplift accepted for 63 beta 11, thanks.
Attachment #9007096 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: qe-verify+

Comment 14

6 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/0a42a880c130
status-firefox63: affected → fixed

Comment 15

6 months ago
This is verified fixed using the latest Firefox 63.0b11 (Build Id:20181001131022) on Windows 10, macOS 10.13.6 and Ubuntu 18.04.
status-firefox63: fixed → verified
Flags: qe-verify+

Updated

6 months ago
tracking-firefox63: + → ---
You need to log in before you can comment on or make changes to this bug.