Closed
Bug 1487580
Opened 6 years ago
Closed 6 years ago
The min-width of devtool need to multiply by zoom value.
Categories
(DevTools :: Framework, enhancement, P3)
DevTools
Framework
Tracking
(firefox64 fixed)
RESOLVED
FIXED
Firefox 64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: mantaroh, Assigned: mantaroh)
References
Details
Attachments
(1 file)
If we zoom in the devtool panel, we can make the devtool width to narrow shorter than sum of buttons width. We need to multiply by zoom to prevent this. (For detail, see the bug 1456056 comment 38 and bug 1468177 comment 1)
Assignee | ||
Comment 1•6 years ago
|
||
WIP: https://hg.mozilla.org/try/rev/bccef03da2fd6d847d307b6562996dbf2f31cdb6 This patch will fix ZoomUI.jsm exception as well.
Assignee | ||
Comment 2•6 years ago
|
||
The toolbox specified the min-width to the own xul attribtue. However, the coordinate system differ from inner and outer frame if we zoom in/out the devtool panel. This patch will multiply the min-width of toolbox and zoom value to prevent this coordinate problem.
Updated•6 years ago
|
Assignee: nobody → mantaroh
Priority: -- → P3
Comment 3•6 years ago
|
||
Comment on attachment 9006125 [details] Bug 1487580 - Multiply the min-width of toolbox and zoom value. r?jdescottes Julian Descottes [:jdescottes][:julian] has approved the revision.
Attachment #9006125 -
Flags: review+
Pushed by mantaroh@gmail.com: https://hg.mozilla.org/integration/autoland/rev/1552bbf660be Multiply the min-width of toolbox and zoom value. r=jdescottes
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1552bbf660be
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 64
You need to log in
before you can comment on or make changes to this bug.
Description
•