Closed
Bug 1487582
Opened 6 years ago
Closed 6 years ago
use Atom to represent Direction values in pseudo-classes
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: heycam, Assigned: heycam)
Details
Attachments
(1 file)
I went with an Atom at the top level of the type, rather than an enum with Other() holding an Atom, to avoid the NonTSPseudoClass type getting bigger.
Assignee | ||
Comment 1•6 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f9d5c33be8a67c3d98473c5ad097018b529b5b96
Assignee | ||
Comment 2•6 years ago
|
||
Comment 3•6 years ago
|
||
Comment on attachment 9005532 [details] Bug 1487582 - Use an Atom to represent Direction values in pseudo-classes. r?xidorn Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9005532 -
Flags: review+
Pushed by cmccormack@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/60f2fed43451 Use an Atom to represent Direction values in pseudo-classes. r=xidorn
Comment 5•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/60f2fed43451
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•