Closed Bug 1487582 Opened Last year Closed Last year

use Atom to represent Direction values in pseudo-classes

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: heycam, Assigned: heycam)

Details

Attachments

(1 file)

I went with an Atom at the top level of the type, rather than an enum with Other() holding an Atom, to avoid the NonTSPseudoClass type getting bigger.
Comment on attachment 9005532 [details]
Bug 1487582 - Use an Atom to represent Direction values in pseudo-classes. r?xidorn

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9005532 - Flags: review+
Pushed by cmccormack@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/60f2fed43451
Use an Atom to represent Direction values in pseudo-classes. r=xidorn
https://hg.mozilla.org/mozilla-central/rev/60f2fed43451
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.