Closed
Bug 1487595
Opened 2 years ago
Closed 2 years ago
Clean up expandlibs related code
Categories
(Firefox Build System :: General, enhancement)
Firefox Build System
General
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
Tracking | Status | |
---|---|---|
firefox63 | --- | fixed |
People
(Reporter: glandium, Assigned: glandium)
References
Details
Attachments
(2 files, 1 obsolete file)
No description provided.
Assignee | ||
Comment 1•2 years ago
|
||
They're both unused since bug 1429875.
Assignee | ||
Comment 2•2 years ago
|
||
Back before expandlibs was removed in bug 1429875, not using list files was supported, but nowadays, it just leads to errors like the following: *** No rule to make target 'libfake_so.list', needed by 'libfake.so'. Stop. We might as well error out during configure, rather than much later during the build. Depends on D4737
Assignee | ||
Comment 3•2 years ago
|
||
At least, when that combination doesn't work. Depends on D4738
![]() |
||
Comment 4•2 years ago
|
||
Comment on attachment 9005546 [details] Bug 1487595 - Remove LIBS_DESC_SUFFIX and EXPAND_LIBS_ORDER_STYLE. r?build Nathan Froyd [:froydnj] has approved the revision.
Attachment #9005546 -
Flags: review+
![]() |
||
Comment 5•2 years ago
|
||
Comment on attachment 9005547 [details] Bug 1487595 - Error out instead of setting EXPAND_LIBS_LIST_STYLE to none. r?build Nathan Froyd [:froydnj] has approved the revision.
Attachment #9005547 -
Flags: review+
![]() |
||
Comment 6•2 years ago
|
||
Comment on attachment 9005548 [details] Bug 1487595 - Avoid using linker scripts as file lists when doing LTO with BFD ld. r?build Nathan Froyd [:froydnj] has approved the revision.
Attachment #9005548 -
Flags: review+
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/f292ef31ef0b Remove LIBS_DESC_SUFFIX and EXPAND_LIBS_ORDER_STYLE. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/d78b833293db Error out instead of setting EXPAND_LIBS_LIST_STYLE to none. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/331706d8558f Avoid using linker scripts as file lists when doing LTO with BFD ld. r=froydnj
Comment 8•2 years ago
|
||
Backed out https://hg.mozilla.org/integration/mozilla-inbound/rev/331706d8558f for win build bustages Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=331706d8558f8dadeba4fbf5f56651130d43f092 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=196970757&repo=mozilla-inbound&lineNumber=1162 Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/dcef4c14d55eb3e5416ba9ce53356449e57e4a0d
Flags: needinfo?(mh+mozilla)
Assignee | ||
Comment 9•2 years ago
|
||
I asked for only the last changeset to be backed out. Meh. Anyways, let's move the problematic part to a separate bug, and reland the cleanup.
Flags: needinfo?(mh+mozilla)
Summary: Clean up expandlibs related code, and work around ld.bfd bug with LTO → Clean up expandlibs related code
Comment 10•2 years ago
|
||
Pushed by mh@glandium.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/d397dc6aa866 Remove LIBS_DESC_SUFFIX and EXPAND_LIBS_ORDER_STYLE. r=froydnj https://hg.mozilla.org/integration/mozilla-inbound/rev/0d4ca5c5e71c Error out instead of setting EXPAND_LIBS_LIST_STYLE to none. r=froydnj
Assignee | ||
Updated•2 years ago
|
Attachment #9005548 -
Attachment is obsolete: true
Comment 11•2 years ago
|
||
Mike, only the last one was backed out, as you requested: glandium> apavel|sheriffduty: backout just 331706d8558f Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/dcef4c14d55eb3e5416ba9ce53356449e57e4a0d
Assignee | ||
Comment 12•2 years ago
|
||
(In reply to Andreea Pavel [:apavel] from comment #11) > Mike, only the last one was backed out, as you requested: > > glandium> apavel|sheriffduty: backout just 331706d8558f > > Backout: > https://hg.mozilla.org/integration/mozilla-inbound/rev/ > dcef4c14d55eb3e5416ba9ce53356449e57e4a0d The backout linked in comment 8 listed all 3 changesets, and the fact that I could apply the patches on top to reland them says all 3 were out.
Assignee | ||
Comment 13•2 years ago
|
||
Ah, so here's what happened: - the 3 changesets were backed out from central, - that one changeset was backed out from inbound, - central was merged to inbound on top of that last backout. The result is that everything was backed out.
Comment 14•2 years ago
|
||
Mike, yes, the backout from central was to fix an accidental push https://hg.mozilla.org/integration/mozilla-inbound/rev/6c83f735355d
Comment 15•2 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d397dc6aa866 https://hg.mozilla.org/mozilla-central/rev/0d4ca5c5e71c
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•