Closed
Bug 1487601
Opened 7 years ago
Closed 7 years ago
Logging improvements in FxAccountsCommands.
Categories
(Firefox :: Firefox Accounts, enhancement)
Firefox
Firefox Accounts
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: rfkelly, Assigned: rfkelly)
Details
Attachments
(1 file)
Two things I noticed while testing the new send-tab implementation:
* FxAccountsCommands._handleCommands() will always log "Unknown command", even if it recognized and handled the command.
* SendTab.handle() logs to the console rather than the sync log file.
Trivial patch incoming...
|
Assignee | |
Updated•7 years ago
|
Assignee: nobody → rfkelly
|
|
Assignee | |
Comment 1•7 years ago
|
||
This patch fixes an accidental switch-statement fall-through that was
causing `_handleCommands()` to always log "Unknown command", and fixes
an inconsistency where one log line was being sent to the console
rather than the sync log file.
|
||
Comment 2•7 years ago
|
||
Comment on attachment 9006100 [details]
Bug 1487601 - Clean up some logging in FxAccountsCommands.
Mark Hammond [:markh] has approved the revision.
Attachment #9006100 -
Flags: review+
Pushed by mhammond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a00e7a0a9f19
Clean up some logging in FxAccountsCommands. r=markh
|
||
Comment 4•7 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•