Closed Bug 1487601 Opened 2 years ago Closed 2 years ago

Logging improvements in FxAccountsCommands.

Categories

(Firefox :: Firefox Accounts, enhancement)

Product:
Firefox
Component:
Firefox Accounts
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: rfkelly, Assigned: rfkelly)

Details

Attachments

(1 file)

Bug 1487601 - Clean up some logging in FxAccountsCommands.
46 bytes, text/x-phabricator-request
markh
: review+
Details | Review 
Two things I noticed while testing the new send-tab implementation:

* FxAccountsCommands._handleCommands() will always log "Unknown command", even if it recognized and handled the command.
* SendTab.handle() logs to the console rather than the sync log file.

Trivial patch incoming...
Assignee: nobody → rfkelly
This patch fixes an accidental switch-statement fall-through that was
causing `_handleCommands()` to always log "Unknown command", and fixes
an inconsistency where one log line was being sent to the console
rather than the sync log file.
Comment on attachment 9006100 [details]
Bug 1487601 - Clean up some logging in FxAccountsCommands.

Mark Hammond [:markh] has approved the revision.
Attachment #9006100 - Flags: review+
Pushed by mhammond@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a00e7a0a9f19
Clean up some logging in FxAccountsCommands. r=markh
https://hg.mozilla.org/mozilla-central/rev/a00e7a0a9f19
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.