Closed Bug 1487601 Opened Last year Closed Last year
Logging improvements in Fx
Accounts Commands .
46 bytes, text/x-phabricator-request
|Details | Review|
Two things I noticed while testing the new send-tab implementation: * FxAccountsCommands._handleCommands() will always log "Unknown command", even if it recognized and handled the command. * SendTab.handle() logs to the console rather than the sync log file. Trivial patch incoming...
This patch fixes an accidental switch-statement fall-through that was causing `_handleCommands()` to always log "Unknown command", and fixes an inconsistency where one log line was being sent to the console rather than the sync log file.
Comment on attachment 9006100 [details] Bug 1487601 - Clean up some logging in FxAccountsCommands. Mark Hammond [:markh] has approved the revision.
Attachment #9006100 - Flags: review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/a00e7a0a9f19 Clean up some logging in FxAccountsCommands. r=markh
You need to log in before you can comment on or make changes to this bug.