Closed
Bug 1487601
Opened Last year
Closed Last year
Logging improvements in FxAccountsCommands.
Categories
(Firefox :: Firefox Accounts, enhancement)
Firefox
Firefox Accounts
Not set
Tracking
()
RESOLVED
FIXED
Firefox 63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: rfkelly, Assigned: rfkelly)
Details
Attachments
(1 file)
Two things I noticed while testing the new send-tab implementation: * FxAccountsCommands._handleCommands() will always log "Unknown command", even if it recognized and handled the command. * SendTab.handle() logs to the console rather than the sync log file. Trivial patch incoming...
|
Assignee | |
Updated•Last year
|
Assignee: nobody → rfkelly
|
|
Assignee | |
Comment 1•Last year
|
||
This patch fixes an accidental switch-statement fall-through that was causing `_handleCommands()` to always log "Unknown command", and fixes an inconsistency where one log line was being sent to the console rather than the sync log file.
|
||
Comment 2•Last year
|
||
Comment on attachment 9006100 [details] Bug 1487601 - Clean up some logging in FxAccountsCommands. Mark Hammond [:markh] has approved the revision.
Attachment #9006100 -
Flags: review+
Pushed by mhammond@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a00e7a0a9f19 Clean up some logging in FxAccountsCommands. r=markh
|
||
Comment 4•Last year
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/a00e7a0a9f19
Status: NEW → RESOLVED
Closed: Last year
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in
before you can comment on or make changes to this bug.
Description
•