Closed Bug 1487615 Opened Last year Closed Last year

The code for bug 1487598 probably needs string escaping.

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: emilio, Assigned: emilio)

References

Details

Attachments

(2 files)

We should probably have a test for it, but I don't think it's sound to just do write!(). CSS Strings should go through CSSStringWriter or str::to_css.
(In case I don't get to it...)
Flags: needinfo?(cam)
Assignee: nobody → emilio
Flags: needinfo?(cam)
We always serialize as an atom, which is the previous behavior (though previous
code was using string escaping which I think was not totally sound either...).
Comment on attachment 9005586 [details]
Simplify the Lang pseudo-class stuff a bit.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9005586 - Flags: review+
Comment on attachment 9005585 [details]
Use proper escaping for pseudo-class strings.

Xidorn Quan [:xidorn] UTC+10 has approved the revision.
Attachment #9005585 - Flags: review+
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/f2ded2a48b5c
Use proper escaping for pseudo-class strings. r=xidorn
Pushed by emilio@crisal.io:
https://hg.mozilla.org/integration/autoland/rev/db4be1902e26
Simplify the Lang pseudo-class stuff a bit. r=xidorn,firefox-style-system-reviewers
https://hg.mozilla.org/mozilla-central/rev/f2ded2a48b5c
https://hg.mozilla.org/mozilla-central/rev/db4be1902e26
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.