Closed Bug 1487781 Opened Last year Closed Last year

Fix the RDM icon fill color when checked

Categories

(DevTools :: Responsive Design Mode, enhancement, P3)

enhancement

Tracking

(firefox63 fixed)

RESOLVED FIXED
Firefox 63
Tracking Status
firefox63 --- fixed

People

(Reporter: gl, Assigned: gl)

Details

Attachments

(2 files)

No description provided.
Attached patch 1487781.patchSplinter Review
Attachment #9005637 - Flags: review?(florens)
Comment on attachment 9005637 [details] [diff] [review]
1487781.patch

Review of attachment 9005637 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #9005637 - Flags: review?(florens) → review+
A lot of icons in the devtools top tab bar use Photon Grey 90 (#0c0c0d) at 100% opacity. This icon and the menu and close icons use Photon Grey 90 at 80% opacity, as specified in https://design.firefox.com/photon/visuals/iconography.html#color

Just mentioning it here, because an alternative fix would be to use `fill: currentColor` in the first selector and just inherit the button’s color, but that would give us the wrong opacity for that icon.

(Ultimately we may or may not want to harmonize both sets of icons, but that's a different issue.)
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8d7c48a6e1cc
Fix the RDM icon fill color when checked. r=fvsch
https://hg.mozilla.org/mozilla-central/rev/8d7c48a6e1cc
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.