1487785 - Add pointer: cursor to the [...] badge in the markup view

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1487785.patch

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1487785.patch

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: 1487785.patch

Comment 4

[Florens Verschelde :fvsch]

Comment on attachment 9005642 [details] [diff] [review]
1487785.patch

Review of attachment 9005642 [details] [diff] [review]:
-----------------------------------------------------------------

When hovering the edges of .markup-expand-badge, we only get some of the visual feedback (color changes but not the cursor change).

The cursor declaration should go on .markup-expand-badge (size=18×13.5), which already has the click event listener and the :hover style, and not on the smalelr .markup-expand-badge::before (size=14×10).

Comment 5

[Florens Verschelde :fvsch]

Attachment: Bug 1487785 - Add pointer cursor to expand badge, vertically align badges; r=gl

Comment 6

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 9005661 [details]
Bug 1487785 - Add pointer cursor to expand badge, vertically align badges; r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a300e2e1517
Add pointer cursor to expand badge and vertically align badges; r=gl

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5a300e2e1517