Add pointer: cursor to the [...] badge in the markup view

RESOLVED FIXED in Firefox 63

Status

P3
normal
RESOLVED FIXED
4 months ago
4 months ago

People

(Reporter: gl, Assigned: fvsch)

Tracking

unspecified
Firefox 63

Firefox Tracking Flags

(firefox63 fixed)

Details

Attachments

(1 attachment, 3 obsolete attachments)

Comment hidden (empty)
(Reporter)

Comment 1

4 months ago
Created attachment 9005638 [details] [diff] [review]
1487785.patch
Attachment #9005638 - Flags: review?(jdescottes)
(Reporter)

Updated

4 months ago
Attachment #9005638 - Flags: review?(jdescottes)
(Reporter)

Comment 2

4 months ago
Created attachment 9005639 [details] [diff] [review]
1487785.patch
Attachment #9005638 - Attachment is obsolete: true
Attachment #9005639 - Flags: review?(jdescottes)
(Reporter)

Comment 3

4 months ago
Created attachment 9005642 [details] [diff] [review]
1487785.patch
Attachment #9005639 - Attachment is obsolete: true
Attachment #9005639 - Flags: review?(jdescottes)
Attachment #9005642 - Flags: review?(florens)
(Assignee)

Comment 4

4 months ago
Comment on attachment 9005642 [details] [diff] [review]
1487785.patch

Review of attachment 9005642 [details] [diff] [review]:
-----------------------------------------------------------------

When hovering the edges of .markup-expand-badge, we only get some of the visual feedback (color changes but not the cursor change).

The cursor declaration should go on .markup-expand-badge (size=18×13.5), which already has the click event listener and the :hover style, and not on the smalelr .markup-expand-badge::before (size=14×10).
Attachment #9005642 - Flags: review?(florens) → review-
(Assignee)

Comment 5

4 months ago
Created attachment 9005661 [details]
Bug 1487785 - Add pointer cursor to expand badge, vertically align badges; r=gl
(Reporter)

Comment 6

4 months ago
Comment on attachment 9005661 [details]
Bug 1487785 - Add pointer cursor to expand badge, vertically align badges; r=gl

Gabriel [:gl] (ΦωΦ) has approved the revision.
Attachment #9005661 - Flags: review+
(Reporter)

Updated

4 months ago
Attachment #9005642 - Attachment is obsolete: true
(Reporter)

Updated

4 months ago
Assignee: gl → florens

Comment 7

4 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5a300e2e1517
Add pointer cursor to expand badge and vertically align badges; r=gl
https://hg.mozilla.org/mozilla-central/rev/5a300e2e1517
Status: ASSIGNED → RESOLVED
Last Resolved: 4 months ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 63
You need to log in before you can comment on or make changes to this bug.