1487795 - Page fragment gets added to the URL twice if the loaded URL already had a fragment

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: General, defect, P1)

Description

[Alessio Placitelli [:Dexter]]

After loading an URL in a new tab that already contains a fragment (the part after the "#" character at the end of the URL), e.g. [1], selecting any link that adds a fragment to the URL will append it at the end, without replacing the original anchor.

STR:

- Load https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#CC_practices
- Scroll the page up and click on the chain icon near "General Practices"

Current output:

- https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#CC_practices#General_C.2FC.2B.2B_Practices

Two fragments are present.

Expected output:

- The awesomebar should contain https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#General_C.2FC.2B.2B_Practices


[1] - https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/Coding_Style#CC_practices

Comment 1

[Mark Banner (:standard8)]

I can't reproduce this on a github page, e.g. https://github.com/protz/thunderbird-conversations#testing

From looking at the original source and comparing with the inspector, it seems h3 elements are declared in the source with the correct id. However, at some stage it looks like javascript is kicking in to insert an anchor and a span within the h3, and this anchor has the incorrect URL.

Moving across to the devmo product, as I think that's more likely the issue at the moment.

Comment 2

[John Whitlock [:jwhitlock]]

A fix is in the open PR https://github.com/mozilla/kuma/pull/4954

Comment 3

[Schalk Neethling [:espressive]]

(In reply to Alessio Placitelli [:Dexter] from comment #0)
> After loading an URL in a new tab that already contains a fragment (the part
> after the "#" character at the end of the URL), e.g. [1], selecting any link
> that adds a fragment to the URL will append it at the end, without replacing
> the original anchor.
> 
> STR:
> 
> - Load
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Coding_Style#CC_practices
> - Scroll the page up and click on the chain icon near "General Practices"
> 
> Current output:
> 
> -
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Coding_Style#CC_practices#General_C.2FC.2B.2B_Practices
> 
> Two fragments are present.
> 
> Expected output:
> 
> - The awesomebar should contain
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Coding_Style#General_C.2FC.2B.2B_Practices
> 
> 
> [1] -
> https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/
> Coding_Style#CC_practices

Hey Alessio,

Just tested this in production using the URL and steps you provided. Seems like this has been fixed?

Comment 4

[John Whitlock [:jwhitlock]]

Thanks Schalk, works for me