1487832 - Port bug 1486739 (Enable ESLint rule comma-dangle on C-C) and bug 1487246 (Enable ESLint rule no-sequences)

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Jorg K (CEST = GMT+2)]

We get heaps of these now:
Missing trailing comma. (comma-dangle)

Geoff, can that be fixed automatically?

Comment 1

[Magnus Melin [:mkmelin]]

Attachment: bug1486739_eslint_comma_dangling.patch

It can.

Comment 2

[Jorg K (CEST = GMT+2)]

What's the plan? Review? Try?

Comment 3

[Jorg K (CEST = GMT+2)]

The patch didn't have calendar/ in it. I'm going to take it now, but can you please do common/ as well:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8c63696d79f6e27872790b1df0787545c83bc550

Comment 4

[Jorg K (CEST = GMT+2)]

Attachment: 1487832-common.patch

--fix, but that doesn't cover everything.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/448242e81ceb
Port 1486739 - fix up mail/ for eslint comma-dangle rule. r=jorgk
https://hg.mozilla.org/comm-central/rev/6a4de2837303
Port 1486739 - fix up .eslintrc.js and commom/ for eslint comma-dangle rule. rs=bustage-fix

Comment 6

[Jorg K (CEST = GMT+2)]

There's no joy to be had, now it's:
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/common/bindings/datetimepicker.xml:805:24 | Unexpected use of comma operator. (no-sequences)
from bug 1487246 :-(

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: 1487832-no-sequences.patch

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4152a59d3d07
Port bug 1487246: fix up commom/ for eslint no-sequences rule. rs=bustage-fix

Comment 9

[Magnus Melin [:mkmelin]]

Forgot to mention, but for anyone else interested, this is the command

 cd comm
 ../mach eslint mail --fix