Port bug 1486739 (Enable ESLint rule comma-dangle on C-C) and bug 1487246 (Enable ESLint rule no-sequences)

RESOLVED FIXED in Thunderbird 63.0

Status

enhancement
RESOLVED FIXED
11 months ago
11 months ago

People

(Reporter: jorgk, Assigned: mkmelin)

Tracking

Thunderbird 63.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

We get heaps of these now:
Missing trailing comma. (comma-dangle)

Geoff, can that be fixed automatically?
Flags: needinfo?(geoff)
It can.
Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
Flags: needinfo?(geoff)
What's the plan? Review? Try?
The patch didn't have calendar/ in it. I'm going to take it now, but can you please do common/ as well:
https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=8c63696d79f6e27872790b1df0787545c83bc550
Keywords: leave-open
Attachment #9005731 - Flags: review+
--fix, but that doesn't cover everything.
Attachment #9005754 - Flags: review?(mkmelin+mozilla)
Keywords: leave-open
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/448242e81ceb
Port 1486739 - fix up mail/ for eslint comma-dangle rule. r=jorgk
https://hg.mozilla.org/comm-central/rev/6a4de2837303
Port 1486739 - fix up .eslintrc.js and commom/ for eslint comma-dangle rule. rs=bustage-fix
Status: ASSIGNED → RESOLVED
Closed: 11 months ago
Resolution: --- → FIXED
There's no joy to be had, now it's:
TEST-UNEXPECTED-ERROR | /builds/worker/checkouts/gecko/comm/common/bindings/datetimepicker.xml:805:24 | Unexpected use of comma operator. (no-sequences)
from bug 1487246 :-(
Target Milestone: --- → Thunderbird 63.0
Summary: Port 1486739 - Enable ESLint rule comma-dangle on C-C → Port bug 1486739 (Enable ESLint rule comma-dangle on C-C) and bug 1487246 (Enable ESLint rule no-sequences)
Attachment #9005794 - Flags: review?(mkmelin+mozilla)
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/4152a59d3d07
Port bug 1487246: fix up commom/ for eslint no-sequences rule. rs=bustage-fix
Attachment #9005754 - Flags: review?(mkmelin+mozilla) → review+
Attachment #9005794 - Flags: review?(mkmelin+mozilla) → review+
Forgot to mention, but for anyone else interested, this is the command

 cd comm
 ../mach eslint mail --fix
You need to log in before you can comment on or make changes to this bug.