1487836 - Fix innerWindowID used for the WebExtensions devtools API eval denied errors

Status: VERIFIED FIXED

(WebExtensions :: Developer Tools, enhancement)

Description

[Luca Greco [:rpl] [:luca] [:lgreco]]

Bug 1476145 we recently removed a number of calls to "getInterface(nsIDOMWindowUtils)" that are not necessary anymore, unfortunately during the mass rewrite we assigned the windowUtils to the var innerWindowId by mistake: 
https://hg.mozilla.org/mozilla-central/diff/640fd7808af5/devtools/server/actors/addon/webextension-inspected-window.js

the warning message is still logged and visible in the browser console, but it not being made visible in the webconsole related to the tab which the warnings is related to.

Comment 1

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1487836 - Fix innerWindowID used for the WebExtensions devtools API eval denied errors.

Comment 2

[Julian Descottes [:jdescottes]]

Comment on attachment 9005679 [details]
Bug 1487836 - Fix innerWindowID used for the WebExtensions devtools API eval denied errors.

Julian Descottes [:jdescottes][:julian] has approved the revision.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/55570b34ff7c
Fix innerWindowID used for the WebExtensions devtools API eval denied errors. r=jdescottes

Comment 4

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/55570b34ff7c

Comment 5

[Vlad Jiman]

Is manual testing required on this bug? If yes, please provide some STR and the proper extension(if required) or set the “qe-verify -“ flag.

Thanks!

Comment 6

[Luca Greco [:rpl] [:luca] [:lgreco]]

STR:
- open a new tab and navigate to https://addons.mozilla.org/en-US/firefox/addon/react-devtools
- install the react devtools addon
- open the webconsole panel from the developer tools for the "addons.mozilla.org" tab (e.g. from the hamburger menu -> "Web Developer" -> "Web Console")

Expected Behavior on the fixed build:
- An error message "The extension "React Developer Tools" is not allowed to access https://addons.mozilla.org/en-US/firefox/addon/react-devtools/..." should be logged in the tab's webconsole 

Actual Behavior on the affected builds:
- No error message ""The extension "React Developer Tools" is not allowed to access ..." in the tab's webconsole
- The error message has been logged to the "Browser Console" (e.g. from the hamburger menu -> "Web Developer" -> "Browser Console")

Comment 7

[Vlad Jiman]

Thank you Luca for clarifying the steps. 
Verified that the issue is no longer reproducible using the latest build of Nightly (07/09/2018) running on Windows 10 x64 and Ubuntu 18.04, both consoles (tab and browser) are showing the error: "The extension "React Developer Tools" is not allowed to access ...".