Closed Bug 1487850 Opened 8 years ago Closed 8 years ago

dom/base/Link.cpp doesn't build if MOZ_PLACES is not defined on non-ANDROID platforms

Categories

(Core :: DOM: Core & HTML, enhancement, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla64
Tracking Flags:
Tracking Status
firefox64 --- fixed

People

(Reporter: fabrice, Assigned: fabrice)

Details

Attachments

(2 files)

Bug 1487850 - Link.cpp doesn't build if MOZ_PLACES is not defined on non-ANDROID platforms r=ehsan
46 bytes, text/x-phabricator-request
ehsan.akhgari
: review+
Details | Review
Bug 1487850 - Link.cpp doesn't build if MOZ_PLACES is not defined on non-ANDROID platforms r=Ehsan
46 bytes, text/x-phabricator-request
Details | Review
No description provided.
The current code only compiles with ANDROID defined when MOZ_PLACES is undefined. This patch sets the history service to nullptr in the remaining case. The value was already null-checked.
Ehsan, I flagged you for review since you made relevant changes in bug 1382923
Assignee: nobody → fabrice
Comment on attachment 9005718 [details] Bug 1487850 - Link.cpp doesn't build if MOZ_PLACES is not defined on non-ANDROID platforms r=ehsan :Ehsan Akhgari has approved the revision.
Attachment #9005718 - Flags: review+
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8e012f9ed34a Link.cpp doesn't build if MOZ_PLACES is not defined on non-ANDROID platforms r=Ehsan
Comment on attachment 9005779 [details] Bug 1487850 - Link.cpp doesn't build if MOZ_PLACES is not defined on non-ANDROID platforms r=Ehsan :Ehsan Akhgari has approved the revision.
Attachment #9005779 - Flags: review+
Flags: needinfo?(ehsan)
Pushed by eakhgari@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/2664e26623fc Link.cpp doesn't build if MOZ_PLACES is not defined on non-ANDROID platforms r=Ehsan
Priority: -- → P3
https://hg.mozilla.org/mozilla-central/rev/2664e26623fc
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox64: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Target Milestone: mozilla64 → mozilla63
Target Milestone: mozilla63 → mozilla64
Comment on attachment 9005779 [details] Bug 1487850 - Link.cpp doesn't build if MOZ_PLACES is not defined on non-ANDROID platforms r=Ehsan :Ehsan Akhgari has been removed from the revision.
Attachment #9005779 - Flags: review+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: