Closed
Bug 1487963
Opened 5 years ago
Closed 5 years ago
PannerNode should throw when parameters are out of range
Categories
(Core :: Web Audio, enhancement, P2)
Core
Web Audio
Tracking
()
RESOLVED
FIXED
mozilla64
Tracking | Status | |
---|---|---|
firefox64 | --- | fixed |
People
(Reporter: manishearth, Assigned: manishearth)
References
Details
(Keywords: dev-doc-complete)
Attachments
(1 file)
refDistance, maxDistance, rolloffFactor, and coneOuterGain all have limits on their values. The spec asks us to throw errors when the values are out of the limits. https://webaudio.github.io/web-audio-api/#dom-pannernode-refdistance
Assignee | ||
Comment 1•5 years ago
|
||
I have patches for this, just need to figure out arcanist. One issue I'm getting is that testing/web-platform/tests/webaudio/the-audio-api/the-pannernode-interface/panner-distance-clamping.html is failing with `FAIL X panner.maxDistance = -1 threw "RangeError" instead of EcmaScript error RangeError. - assert_true: expected true got false` Not sure what's going on there, is this a bug with the test?
Assignee | ||
Comment 2•5 years ago
|
||
Assignee | ||
Comment 3•5 years ago
|
||
I'll also need to include https://github.com/servo/servo/pull/21555/commits/e1131b474c7d162ec791c10f0bc21ecca56100d7 to make this work, not sure if I should just wait for the sync to happen or copy over the test.
Comment 4•5 years ago
|
||
Comment on attachment 9005788 [details] Bug 1487963 - Throw when setting PannerNode parameters out of limits; r?padenot Andrea Marchesini [:baku] has approved the revision.
Attachment #9005788 -
Flags: review+
Comment 5•5 years ago
|
||
Comment on attachment 9005788 [details] Bug 1487963 - Throw when setting PannerNode parameters out of limits; r?padenot Paul Adenot (:padenot) has approved the revision.
Attachment #9005788 -
Flags: review+
Updated•5 years ago
|
Rank: 19
Priority: -- → P2
Assignee | ||
Comment 6•5 years ago
|
||
try https://treeherder.mozilla.org/#/jobs?repo=try&revision=2b20dd7cf9d09f10976626604c4099fea93964d9
Pushed by manishearth@gmail.com: https://hg.mozilla.org/integration/autoland/rev/da0384fb1fbb Throw when setting PannerNode parameters out of limits; r=padenot,baku
Comment 8•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/da0384fb1fbb
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
Comment 9•5 years ago
|
||
cover the exceptions and in range values in our docs.
Keywords: dev-doc-needed
Comment 10•5 years ago
|
||
I've documented the exceptions for these properties, and indicated more clearly what their acceptable ranges are: https://developer.mozilla.org/en-US/docs/Web/API/PannerNode/PannerNode https://developer.mozilla.org/en-US/docs/Web/API/PannerNode/coneOuterGain https://developer.mozilla.org/en-US/docs/Web/API/PannerNode/maxDistance https://developer.mozilla.org/en-US/docs/Web/API/PannerNode/rolloffFactor https://developer.mozilla.org/en-US/docs/Web/API/PannerNode/refDistance I've also added a note to the Fx 64 rel notes: https://developer.mozilla.org/en-US/docs/Mozilla/Firefox/Releases/64#APIs Let me know if this looks OK. Thanks!
Flags: needinfo?(manishearth)
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•