Closed Bug 1487979 Opened 2 years ago Closed 2 years ago

Combine @media (-moz-windows-classic) rules in tree.css

Categories

(Toolkit :: Themes, enhancement, P3)

All
Windows
enhancement

Tracking

()

RESOLVED FIXED
mozilla64
Tracking Status
firefox64 --- fixed

People

(Reporter: dao, Assigned: arika.arnzen, Mentored)

Details

(Keywords: good-first-bug, Whiteboard: [lang=css])

Attachments

(1 file, 1 obsolete file)

We have two @media (-moz-windows-classic) rules right next to each other, let's combine them:

https://searchfox.org/mozilla-central/rev/43969de34f5d4b113133d090f024e5eed7a82af0/toolkit/themes/windows/global/tree.css#21,31
Priority: -- → P3
I would like to start working on this if no one else is!
(In reply to arika.arnzen from comment #1)
> I would like to start working on this if no one else is!

Go ahead!
Assignee: nobody → arika.arnzen
Attached patch tree.css (obsolete) — Splinter Review
Here is a suggested patch for this problem. Please let me know any further steps that need to be taken for this issue.
Here is the actual patch information.
Comment on attachment 9007084 [details] [diff] [review]
treeChanges.patch

Perfect, thanks!
Attachment #9007084 - Flags: review+
Comment on attachment 9007070 [details] [diff] [review]
tree.css

No need to attach changed files, we only need the patch. :)
Attachment #9007070 - Attachment is obsolete: true
Keywords: checkin-needed
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69f608b5cdc6
Combine @media (-moz-windows-classic) rules in tree.css. r=dao
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/69f608b5cdc6
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.