Closed
Bug 1487979
Opened 6 years ago
Closed 6 years ago
Combine @media (-moz-windows-classic) rules in tree.css
Categories
(Toolkit :: Themes, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla64
| Tracking | Status | |
|---|---|---|
| firefox64 | --- | fixed |
People
(Reporter: dao, Assigned: arika.arnzen, Mentored)
Details
(Keywords: good-first-bug, Whiteboard: [lang=css])
Attachments
(1 file, 1 obsolete file)
|
1.77 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
We have two @media (-moz-windows-classic) rules right next to each other, let's combine them: https://searchfox.org/mozilla-central/rev/43969de34f5d4b113133d090f024e5eed7a82af0/toolkit/themes/windows/global/tree.css#21,31
|
Reporter | |
Updated•6 years ago
|
Priority: -- → P3
|
Assignee | |
Comment 1•6 years ago
|
||
I would like to start working on this if no one else is!
|
|
Reporter | |
Comment 2•6 years ago
|
||
(In reply to arika.arnzen from comment #1) > I would like to start working on this if no one else is! Go ahead!
|
|
Reporter | |
Updated•6 years ago
|
Assignee: nobody → arika.arnzen
|
|
Assignee | |
Comment 3•6 years ago
|
||
Here is a suggested patch for this problem. Please let me know any further steps that need to be taken for this issue.
|
|
Assignee | |
Comment 4•6 years ago
|
||
Here is the actual patch information.
|
|
Reporter | |
Comment 5•6 years ago
|
||
Comment on attachment 9007084 [details] [diff] [review] treeChanges.patch Perfect, thanks!
Attachment #9007084 -
Flags: review+
|
|
Reporter | |
Comment 6•6 years ago
|
||
Comment on attachment 9007070 [details] [diff] [review] tree.css No need to attach changed files, we only need the patch. :)
Attachment #9007070 -
Attachment is obsolete: true
|
|
Reporter | |
Updated•6 years ago
|
Keywords: checkin-needed
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/69f608b5cdc6 Combine @media (-moz-windows-classic) rules in tree.css. r=dao
Keywords: checkin-needed
|
||
Comment 8•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/69f608b5cdc6
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox64:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in
before you can comment on or make changes to this bug.
Description
•