Combine @media (-moz-windows-classic) rules in tree.css

RESOLVED FIXED in Firefox 64

Status

()

enhancement
P3
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: dao, Assigned: arika.arnzen, Mentored)

Tracking

({good-first-bug})

Trunk
mozilla64
All
Windows
Points:
---

Firefox Tracking Flags

(firefox64 fixed)

Details

(Whiteboard: [lang=css])

Attachments

(1 attachment, 1 obsolete attachment)

Reporter

Description

9 months ago
We have two @media (-moz-windows-classic) rules right next to each other, let's combine them:

https://searchfox.org/mozilla-central/rev/43969de34f5d4b113133d090f024e5eed7a82af0/toolkit/themes/windows/global/tree.css#21,31
Reporter

Updated

9 months ago
Priority: -- → P3
Assignee

Comment 1

9 months ago
I would like to start working on this if no one else is!
Reporter

Comment 2

9 months ago
(In reply to arika.arnzen from comment #1)
> I would like to start working on this if no one else is!

Go ahead!
Reporter

Updated

9 months ago
Assignee: nobody → arika.arnzen
Assignee

Comment 3

9 months ago
Posted patch tree.css (obsolete) — Splinter Review
Here is a suggested patch for this problem. Please let me know any further steps that need to be taken for this issue.
Assignee

Comment 4

9 months ago
Here is the actual patch information.
Reporter

Comment 5

9 months ago
Comment on attachment 9007084 [details] [diff] [review]
treeChanges.patch

Perfect, thanks!
Attachment #9007084 - Flags: review+
Reporter

Comment 6

9 months ago
Comment on attachment 9007070 [details] [diff] [review]
tree.css

No need to attach changed files, we only need the patch. :)
Attachment #9007070 - Attachment is obsolete: true
Reporter

Updated

9 months ago
Keywords: checkin-needed

Comment 7

9 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/69f608b5cdc6
Combine @media (-moz-windows-classic) rules in tree.css. r=dao
Keywords: checkin-needed

Comment 8

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/69f608b5cdc6
Status: NEW → RESOLVED
Last Resolved: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla64
You need to log in before you can comment on or make changes to this bug.