1487986 - webdriver: Prefer x.is_empty() over x.len() == 0

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

It is considered better Rust style to use x.is_empty() over x.len()
== 0, so we should do that.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: webdriver: prefer x.is_empty() over x.len() == 0

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Comment on attachment 9005815 [details] [diff] [review]
webdriver: prefer x.is_empty() over x.len() == 0

Review of attachment 9005815 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/webdriver/src/capabilities.rs
@@ +387,5 @@
>          &self,
>          browser_capabilities: &mut T,
>      ) -> WebDriverResult<Option<Capabilities>> {
>          let default = vec![Map::new()];
> +        let capabilities_list = if self.firstMatch.is_empty() {

You reverse the condition here, which should fail the wdspec tests too.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: webdriver: prefer x.is_empty() over x.len() == 0

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecdba8d9bb22
webdriver: prefer x.is_empty() over x.len() == 0; r=whimboo

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ecdba8d9bb22