Closed Bug 1487987 Opened 3 years ago Closed 3 years ago

Port bug 1469688 to TB: Allow reordering the precedence of installed language packs

Categories

(Thunderbird :: Preferences, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 63.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file, 1 obsolete file)

Bug 1469688 introduced a dialog to reorder the installed locales.
Attached patch languages-reorder.patch (obsolete) — Splinter Review
Port of https://hg.mozilla.org/mozilla-central/rev/505226ad06ab, https://hg.mozilla.org/mozilla-central/rev/6edbb5f98d6e, https://hg.mozilla.org/mozilla-central/rev/bcec32bfccff and, https://hg.mozilla.org/mozilla-central/rev/55662a7bc29c.

I copied the messengerLanguages.* files from browser directory and changed all "browser" to "messenger" and adapted messengerLanguages.js to work with gAdvancedPane instead of gMainePane.

You can try with the French locale which seems to be the most complete for the ftl files.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9005818 - Flags: review?(jorgk)
Comment on attachment 9005818 [details] [diff] [review]
languages-reorder.patch

I few comments here:

I got some Win64 language packs from here:
http://ftp.mozilla.org/pub/thunderbird/nightly/2018/08/2018-08-23-10-02-50-comm-central-l10n/win64/xpi/
I installed DE, ES, FR.

The alternatives work, holes in the DE localisation are filled by some other chosen language. I wasn't able to check the case where also the first alternative had the same hole and it would default to the second alternative.

At first, the alternatives show only en-US, only if you apply a language pack will it appear under alternatives.
Why don't all installed language packs always show up under alternatives. I've chosen DE, FR and en-US as primary languages, one after the other. They now show under alternatives, ES still doesn't show since I never applied it.

The alternatives windows opens too small after a restart, you can't see the buttons.

When I restart the session after changing the alternative, I get this in the debug console:

JavaScript error: resource://gre/modules/L10nRegistry.jsm, line 207: TypeError:
L10nRegistry.sources.get(...) is undefined, can't access property "hasFile" of it
JavaScript error: , line 0: uncaught exception: undefined

I understand this is a port, but it doesn't quite work, maybe because the original has those errors. Please check a *debug* version of FF to see whether these three problems exist there. If so, please file a bug.

Clearing the review for now. I will accept it if all those problems exist in FF. Then there is hope they will get fixed and we can follow those fixes.

You want to know a crazy thing? They implement a 1st, 2nd and 3rd fallback, but bug 
1379910 is still not done in FF :-(
Attachment #9005818 - Flags: review?(jorgk)
FX has the same problems:

- A language needs first applied to show in the list.
- The TypeError.

The hidden buttons I haven't seen but this can be from other influences like window size or already translated parts. I saw it also on TB when switching from English to French. But after resizing the window I don't see it.

What's also funny, on TB and FX, when you disable the language packs they are no more shown in the menulist, but still in the Alternatives dialog. And when you change the language in the dialog and restart, the menulist is empty.
I'll try to make the dialog better flexing. Actually you can make it tall and the listbox has still a fixed height.
Patch with a better flexing dialog.
Attachment #9005818 - Attachment is obsolete: true
Attachment #9005904 - Flags: review?(jorgk)
Comment on attachment 9005904 [details] [diff] [review]
languages-reorder.patch

Yep, not the alternatives dialogue comes up in a good size with the buttons visible.

Have you filed the FF bug for the problems we detected? We're shipping something in beta 63 from next week that doesn't work properly :-(
Attachment #9005904 - Flags: review?(jorgk) → review+
Not yet filed.
Keywords: checkin-needed
Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/f5e4d855c2a8
Port bug 1469688 to TB: Allow reordering the precedence of installed language packs. r=jorgk
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 63.0
(In reply to Richard Marti (:Paenglab) from comment #8)
> Not yet filed.
Filed bug 1488099.
Type: enhancement → task
Type: task → enhancement
You need to log in before you can comment on or make changes to this bug.