1487993 - webdriver: Loop over references to containers instead of using explicit iteration methods

Status: RESOLVED FIXED

(Testing :: geckodriver, enhancement)

Description

[Andreas Tolfsen ❲:ato❳]

Instead of x.iter() we can simply do &x.

Comment 1

[Andreas Tolfsen ❲:ato❳]

Attachment: webdriver: avoid explicitly calling iteration protocols

Instead of making explicit calls to iterator protocol methods such as
x.iter() or x.into_iter(), we can loop over references to collections.
This is considered better style.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 9005824 [details] [diff] [review]
webdriver: avoid explicitly calling iteration protocols

Review of attachment 9005824 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/webdriver/src/capabilities.rs
@@ +189,5 @@
>              ErrorStatus::InvalidArgument,
>              "proxy is not an object"
>          );
>  
> +        for (key, value) in obj {

Isn't that also possible for line 125? I also see a couple more of those things to fix.

Comment 3

[Andreas Tolfsen ❲:ato❳]

Attachment: webdriver: avoid explicitly calling iteration protocols

Instead of making explicit calls to iterator protocol methods such as
x.iter() or x.into_iter(), we can loop over references to collections.
This is considered better style.

Comment 4

[Andreas Tolfsen ❲:ato❳]

(In reply to Henrik Skupin (:whimboo) from comment #2)

> Isn't that also possible for line 125? I also see a couple more of those
> things to fix.

Indeed.  Strange the linter didn’t complain about those…

There’s one instance still left, but in that case serde doesn’t
implement the Iter trait so we need to call it explicitly.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Comment on attachment 9005993 [details] [diff] [review]
webdriver: avoid explicitly calling iteration protocols

Review of attachment 9005993 [details] [diff] [review]:
-----------------------------------------------------------------

r=wc

::: testing/webdriver/src/capabilities.rs
@@ +414,5 @@
>              })
>              .map(|merged| merged.and_then(|x| self.validate(x, browser_capabilities)))
>              .collect::<WebDriverResult<Vec<Capabilities>>>()?;
>  
>          let selected = merged_capabilities

Note, that there is one more instance in line 423.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ecbda656977
webdriver: avoid explicitly calling iteration protocols; r=whimboo

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/2ecbda656977