Closed
Bug 1487995
Opened 6 years ago
Closed 6 years ago
webdriver: Avoid redundant closures
Categories
(Testing :: geckodriver, enhancement)
Testing
geckodriver
Tracking
(firefox63 fixed)
RESOLVED
FIXED
mozilla63
| Tracking | Status | |
|---|---|---|
| firefox63 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
Details
Attachments
(1 file)
|
1.08 KB,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
cargo clippy warns us that the webdriver library has some redundant closures that we should avoid.
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•6 years ago
|
||
The deserialised value is already Some({u,i}64).
Attachment #9005826 -
Flags: review?(hskupin)
|
||
Comment 2•6 years ago
|
||
Comment on attachment 9005826 [details] [diff] [review] webdriver: avoid redundant mapping closure Review of attachment 9005826 [details] [diff] [review]: ----------------------------------------------------------------- Hurray for very little perf improvements too...
Attachment #9005826 -
Flags: review?(hskupin) → review+
Pushed by ato@sny.no: https://hg.mozilla.org/integration/mozilla-inbound/rev/70b142cc123a webdriver: avoid redundant mapping closure; r=whimboo
|
||
Comment 4•6 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/70b142cc123a
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox63:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in
before you can comment on or make changes to this bug.
Description
•